Build navigator should have stage/job picker above build details
The stage/job picker is supposed to be above the build details: https://gitlab.com/gitlab-org/gitlab-ce/issues/18516#note_13891481
But instead it's below:
Activity
Reassigned to @lbennett
@markpundsack This is how it was originally, but I made an MR for adding it below as it makes sense that the details for the build that is being viewed take priority over links that take you away to different builds. Also the scroll-within-a-scroll-within-a-scroll can introduce complications on smaller devices.
If UX disagrees I will revert this personally.
Added ~19492 and removed frontend ~12980 labels
OK, I understand the reasoning so if that's what UX wants, I'm fine with it. It was mainly jarring for me because I wasn't expecting it.
Of course now that I'm staring at it, I do feel like it looks a little out of place at the bottom, but maybe that's just because there's no words or other context to explain it. Or because the build/job scroller is full-width, whereas the stage has a separator with padding; the net effect being that the stage looks like part of the build details, but the build list is outside. Not explaining very well, sorry.
@jschatz1 BTW, this would be a great example of something that would benefit buy user testing. :)
-
@markpundsack I'm following, I did take a look at making the build scroller thinner instead of full-width, but didn't like it, in fact it took some hacking to get it full-width AFAIR. Let's have UX take a look at whether we can fit it in a bit better. Is probably a good case for UAT indeed.
