Webhooks should not be triggered when no change is made

Related to: #19472 (closed), !5071 (merged)

Currently if we PUT /gitlab-org/gitlab-ce/issues/1234.json with an array of issue[label_ids][] identical to the labels already assigned to an issue, it will erroneously trigger web hooks. There should be a check to determine whether the issue has in fact been changed in any meaningful way before triggering webhooks or other services. I'm not sure if this applies only to issue labels or more broadly to all PUT requests on this endpoint, but thought should be given to where else this may be an issue (merge requests, etc.).

/cc @dbalexandre @rymai @DouweM

Thanks @mikegreiling, nice find!

@DouweM @dbalexandre In IssuableBaseService we could change

def update_issuable(issuable, attributes)
  issuable.with_transaction_returning_status do
    issuable.update(attributes.merge(updated_by: current_user))
  end
end

to

def update_issuable(issuable, attributes)
  status =
    issuable.with_transaction_returning_status do
      issuable.attributes = attributes
      issuable.update(updated_by: current_user) if issuable.changed?
    end
  status && issuable.previous_changes.present?
end

This was not tested but you get the idea.

@DouweM I think this should be scheduled for 8.13.

Added ~874211 and removed ~480950 labels

moved to gitlab#6406

Hey!

GitLab is moving all development for both GitLab Community Edition and Enterprise Edition into a single codebase. The current gitlab-ce repository will become a read-only mirror, without any proprietary code. All development is moved to the current gitlab-ee repository, which we will rename to just gitlab in the coming weeks. As part of this migration, issues will be moved to the current gitlab-ee project.

If you have any questions about all of this, please ask them in our dedicated FAQ issue.

https://gitlab.com/gitlab-org/gitlab-ee/issues/13855

You can also find more information here:

• https://gitlab.com/gitlab-org/gitlab-ee/issues/13304
• https://about.gitlab.com/2019/08/23/a-single-codebase-for-gitlab-community-and-enterprise-edition/

Frequently Asked Questions

For an up to date list of questions and answers, please take a look at https://gitlab.com/gitlab-org/gitlab-ee/issues/13855

What will we do with the repository names?

https://gitlab.com/gitlab-org/gitlab-ee/ will become https://gitlab.com/gitlab-org/gitlab, and https://gitlab.com/gitlab-org/gitlab-ce will become https://gitlab.com/gitlab-org/gitlab-foss.

Why rename gitlab-ce to gitlab-foss?

Using "gitlab" and "gitlab-ce" would be confusing, so we decided to rename gitlab-ce to gitlab-foss to make the purpose of this FOSS repository more clear

I created a merge requests for CE, and this got closed. What do I need to do?

You will need to create a merge request at https://gitlab.com/gitlab-org/gitlab-ee/. This link will eventually redirect to https://gitlab.com/gitlab-org/gitlab.

How does the licensing work in this new setup?

Everything in the ee/ directory is proprietary. Everything else is free and open source software. If your merge request does not change anything in the ee/ directory, the process of contributing changes is the same as when using the gitlab-ce repository.

Will you accept merge requests on the gitlab-ce/gitlab-foss project after it has been renamed?

No. Merge requests submitted to this project will be closed automatically.

Will I still be able to view old issues and merge requests in gitlab-ce/gitlab-foss?

Yes.

How will this affect users of GitLab CE using Omnibus?

No changes will be necessary, as the packages built remain the same.

How will this affect users of GitLab CE that build from source?

Once the project has been renamed, you will need to change your Git remotes to use this new URL. GitLab will take care of redirecting Git operations so there is no hard deadline, but we recommend doing this as soon as the projects have been renamed.

Where can I see a timeline of the remaining steps?

https://gitlab.com/gitlab-org/gitlab-ee/issues/13304

Will community contributions submitted to the new "gitlab" repository be available in the new gitlab-foss repository?

Yes, these changes will be synced to gitlab-foss automatically, several times per day.

locked this issue