Stylize labels as labels when editing them in the Issue sidebar

Proposal: Style the labels like labels, but crop them to a line, and always add new labels at the front of the list

Current design:

Proposed design:

Is this referencing this?

If not, can you clarify what you mean? cc @sytses

For me collapse icon makes sense only when you expand/collapse same UI element like this:

However labels/assignee dropdown on sidebar is something that you close (hide completely) rather than reduce in side (collapse)

For me collapse icon makes sense only when you expand/collapse same UI element like this

Yes, I agree with this. I think the close icon makes sense for the labels dropdown. I'm not sure what the argument is for having it be a collapse icon.

Problem: Sid is not sure that added label will be saved when pressing close.

How can we make users understand that labels are added even before the close?

cc: @sytses, @dzaporozhets @jschatz1

@tauriedavis and I just realized that there may be a bug in the current GitLab CE Project that could be adding to this confusion. In a personal test project, when I select labels on an issue, the text in the dropdown field updates, showing the last label I applied. On the GitLab CE Project, the text in the dropdown only ever says 'Label'.

@sytses: If you saw the dropdown field update when you click on a label, would you feel more confident that the label will be added, and ok with pressing close?

Added ~761915 ~65372 labels

Removed ~761915 ~65372 labels

@awhildy mmm, that would not help me so much. I think @tauriedavis suggested opening the many below the labels so you can see the existing labels and new labels being added. The current text field is strange, it doesn't look and feel like a label.

The current text field is strange, it doesn't look and feel like a label.

I agree it doesn't look and feel like a label but the number does increase as you select more labels so it gives the feel that labels are added even before the close.

I think @tauriedavis suggested opening the many below the labels so you can see the existing labels

I'm not sure this would work as well. As you add more labels, the menu would keep moving down and I don't think we should move the dropdown as users are using it.

cc @awhildy What are your thoughts here?

@tauriedavis: I agree we don't want the dropdown menu to have to move to accommodate the labels. I wonder if part of the problem is that the labels don't look like labels when they are in the current text field. What if we style the labels like labels, but crop them to a line, and always add new labels at the front of the list?

That looks good to me @awhildy

Added frontend and removed ~19492 labels

Changed title: Suggestion: When adding labels the close icon should be a collapse one → Stylize labels as labels when editing them in the Issue sidebar

Milestone changed to %8.15

Mentioned in issue #24774 (moved)

Added ~163085 label

Added ~874211 label

changed milestone to %Backlog

removed milestone

moved to gitlab#6517

Hey!

GitLab is moving all development for both GitLab Community Edition and Enterprise Edition into a single codebase. The current gitlab-ce repository will become a read-only mirror, without any proprietary code. All development is moved to the current gitlab-ee repository, which we will rename to just gitlab in the coming weeks. As part of this migration, issues will be moved to the current gitlab-ee project.

If you have any questions about all of this, please ask them in our dedicated FAQ issue.

https://gitlab.com/gitlab-org/gitlab-ee/issues/13855

You can also find more information here:

• https://gitlab.com/gitlab-org/gitlab-ee/issues/13304
• https://about.gitlab.com/2019/08/23/a-single-codebase-for-gitlab-community-and-enterprise-edition/

Frequently Asked Questions

For an up to date list of questions and answers, please take a look at https://gitlab.com/gitlab-org/gitlab-ee/issues/13855

What will we do with the repository names?

https://gitlab.com/gitlab-org/gitlab-ee/ will become https://gitlab.com/gitlab-org/gitlab, and https://gitlab.com/gitlab-org/gitlab-ce will become https://gitlab.com/gitlab-org/gitlab-foss.

Why rename gitlab-ce to gitlab-foss?

Using "gitlab" and "gitlab-ce" would be confusing, so we decided to rename gitlab-ce to gitlab-foss to make the purpose of this FOSS repository more clear

I created a merge requests for CE, and this got closed. What do I need to do?

You will need to create a merge request at https://gitlab.com/gitlab-org/gitlab-ee/. This link will eventually redirect to https://gitlab.com/gitlab-org/gitlab.

How does the licensing work in this new setup?

Everything in the ee/ directory is proprietary. Everything else is free and open source software. If your merge request does not change anything in the ee/ directory, the process of contributing changes is the same as when using the gitlab-ce repository.

Will you accept merge requests on the gitlab-ce/gitlab-foss project after it has been renamed?

No. Merge requests submitted to this project will be closed automatically.

Will I still be able to view old issues and merge requests in gitlab-ce/gitlab-foss?

Yes.

How will this affect users of GitLab CE using Omnibus?

No changes will be necessary, as the packages built remain the same.

How will this affect users of GitLab CE that build from source?

Once the project has been renamed, you will need to change your Git remotes to use this new URL. GitLab will take care of redirecting Git operations so there is no hard deadline, but we recommend doing this as soon as the projects have been renamed.

Where can I see a timeline of the remaining steps?

https://gitlab.com/gitlab-org/gitlab-ee/issues/13304

Will community contributions submitted to the new "gitlab" repository be available in the new gitlab-foss repository?

Yes, these changes will be synced to gitlab-foss automatically, several times per day.

locked this issue