Intermittent spec failures in spec/features/atom/users_spec.rb
https://gitlab.com/gitlab-org/gitlab-ce/builds/4893179
Looking at the test.log, I think there is some issue where a username with periods and .atom
causes a 302 redirect to the user page:
Started GET "/chauncey.bogisich1.atom?private_token=[FILTERED]" for 127.0.0.1 at 2016-10-08 09:08:49 -0700
Processing by NamespacesController#show as ATOM
Parameters: {"private_token"=>"[FILTERED]", "id"=>"chauncey.bogisich1"}
User Load (0.6ms) SELECT "users".* FROM "users" WHERE "users"."authentication_token" = $1 ORDER BY "users"."id" DESC LIMIT 1 [["authentication_token", "eLVuzFUd4adkpQu1oEzs"]]
(0.2ms) SAVEPOINT active_record_1
SQL (0.4ms) UPDATE "users" SET "last_sign_in_at" = $1, "current_sign_in_at" = $2, "last_sign_in_ip" = $3, "current_sign_in_ip" = $4, "sign_in_count" = $5, "updated_at" = $6 WHERE "users"."id" = $7 [["last_sign_in_at", "2016-10-08 16:08:50.029921"], ["current_sign_in_at", "2016-10-08 16:08:50.029921"], ["last_sign_in_ip", "127.0.0.1"], ["current_sign_in_ip", "127.0.0.1"], ["sign_in_count", 1], ["updated_at", "2016-10-08 16:08:50.031390"], ["id", 1]]
Namespace Load (0.3ms) SELECT "namespaces".* FROM "namespaces" WHERE "namespaces"."deleted_at" IS NULL AND "namespaces"."owner_id" = $1 AND "namespaces"."type" IS NULL ORDER BY "namespaces"."id" DESC LIMIT 1 [["owner_id", 1]]
(0.1ms) RELEASE SAVEPOINT active_record_1
ApplicationSetting Load (0.3ms) SELECT "application_settings".* FROM "application_settings" ORDER BY "application_settings"."id" DESC LIMIT 1
ActiveRecord::SchemaMigration Load (0.3ms) SELECT "schema_migrations".* FROM "schema_migrations"
Namespace Load (0.3ms) SELECT "namespaces".* FROM "namespaces" WHERE "namespaces"."deleted_at" IS NULL AND "namespaces"."path" = $1 ORDER BY "namespaces"."id" DESC LIMIT 1 [["path", "chauncey.bogisich1"]]
User Load (0.3ms) SELECT "users".* FROM "users" WHERE "users"."id" = $1 ORDER BY "users"."id" DESC LIMIT 1 [["id", 1]]
Redirected to http://www.example.com/chauncey.bogisich1
Completed 302 Found in 41ms (ActiveRecord: 3.6ms)
Started GET "/chauncey.bogisich1" for 127.0.0.1 at 2016-10-08 09:08:50 -0700
Group Load (0.3ms) SELECT "namespaces".* FROM "namespaces" WHERE "namespaces"."deleted_at" IS NULL AND "namespaces"."type" IN ('Group') AND "namespaces"."path" = $1 ORDER BY "namespaces"."id" DESC LIMIT 1 [["path", "chauncey.bogisich1"]]
User Load (0.4ms) SELECT "users".* FROM "users" WHERE (lower(username) = 'chauncey.bogisich1') ORDER BY "users"."id" DESC LIMIT 1
Processing by UsersController#show as
Parameters: {"username"=>"chauncey"}
ApplicationSetting Load (0.3ms) SELECT "application_settings".* FROM "application_settings" ORDER BY "application_settings"."id" DESC LIMIT 1
ActiveRecord::SchemaMigration Load (0.3ms) SELECT "schema_migrations".* FROM "schema_migrations"
User Load (0.5ms) SELECT "users".* FROM "users" WHERE (lower(username) = 'chauncey') ORDER BY "users"."id" DESC LIMIT 1
ActiveRecord::RecordNotFound (Couldn't find User):
app/models/user.rb:270:in `find_by_username!'
app/controllers/users_controller.rb:95:in `user'
lib/gitlab/request_profiler/middleware.rb:15:in `call'
lib/gitlab/middleware/go.rb:16:in `call'
lib/gitlab/middleware/static.rb:9:in `call'
Rendered public/404.html (0.6ms)
Completed 404 Not Found in 160ms (Views: 139.6ms | ActiveRecord: 1.9ms)