Filter by milestones is broken when title contains apostrophe
Summary
If you create a milestone with an apostrophe in the title, then the filter for issues is broken.
Steps to reproduce
- create a milestone with this title: "J'aime GITLAB"
- go to issues list
- open the milestone list in the filter. There is only 2 line and the wheel rotate indefinitely
Expected behavior
All milestones in the list.
Actual behavior
List is empty.
Relevant logs and/or screenshots
In chrome console there is this alert :
Output of checks
Results of GitLab application Check
gitlab check is ok on my side.
GitLab Shell version >= 3.6.1 ? ... OK (3.6.1)
...
Results of GitLab environment info
gitlab-rake gitlab:env:info
System information
System: Ubuntu 16.04
Current User: git
Using RVM: no
Ruby Version: 2.3.1p112
Gem Version: 2.6.6
Bundler Version:1.13.1
Rake Version: 10.5.0
Sidekiq Version:4.1.4
GitLab information
Version: 8.12.3
Revision: 467e1ca
Directory: /opt/gitlab/embedded/service/gitlab-rails
DB Adapter: postgresql
URL: https://...
HTTP Clone URL: https://...
SSH Clone URL: ...
Using LDAP: no
Using Omniauth: no
GitLab Shell
Version: 3.6.1
Repository storage paths:
- default: /home/gitlab/git-data/repositories
Hooks: /opt/gitlab/embedded/service/gitlab-shell/hooks/
Git: /opt/gitlab/embedded/bin/git
Possible fixes
Maybe escape title in javascript.