Replace Admin Settings with a tab

Group Admin Settings similar to how we are grouping Project Settings (https://gitlab.com/gitlab-org/gitlab-ce/issues/23007), and replace the dropdown with a tab.

• General (settings)
• Deploy Keys
• Service Templates
• Labels
• Appearance

cc @tauriedavis @dzaporozhets @annabeldunstone

Current Admin Settings pages:

Mentioned in issue #22171 (moved)

Mentioned in issue #23007 (closed)

Not very many settings here compared to projects. We can probably just keep them the same but as tabs:

• General (settings)
• Deploy Keys
• Service Templates
• Labels
• Appearance

cc @awhildy @dzaporozhets

@tauriedavis: Sounds good to me. Would you change the name of 'Deploy Keys' to 'Repository' to map what we call the page with that content on the project settings in #23007 (closed)? Or would that add confusion since it really is just Deploy Keys?

Mentioned in issue #23304 (closed)

Yeah, I don't think I would change the name because there are actual deploy keys within repository on the project page. If there was two sections within admin settings that were both in repository section of the project settings, then I'd group them and name them repository. But since there is only one, it makes more sense to just call what it is to me.

Mentioned in issue #23593 (closed)

Makes sense. Thanks!

Added frontend label

Removed ~19492 label

Somewhat dependent on https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/6999 to reuse styles etc

Milestone changed to %8.15

Added settings label

changed milestone to %Backlog

mentioned in issue #3539 (moved)

Will this be planned for 9.0, or later?

We are looking to make this change for Project settings, Group settings and Admin settings (meta: https://gitlab.com/gitlab-org/gitlab-ce/issues/23593). Project settings was the most complicated (required some reorganization of pages), so we focused on that first. We are making great progress with that, and are hopeful to get that moved to tabs for this release (8.17). Group and Admin settings are simpler (I don't think any of the pages have to be combined). @victorwu - Thoughts on when we could schedule this and Group settings (https://gitlab.com/gitlab-org/gitlab-ce/issues/23304)?

Related conversation here: https://gitlab.com/gitlab-org/gitlab-ce/issues/3539#note_21975010

Settings tabs may need to be updated to include Authentication:

• General (settings)
• Deploy Keys
• Authentication
• Service Templates
• Labels
• Appearance

And just for a quick visual :)

Not sure who is working on this at the moment, but wanted to drop in a remark that @stanhu screenshared the admin settings panel with me, and I could not help but notice it involved about three pages worth of scrolling and no clear organization of topics that I could see... no table of contents at the top, or areas that expand and collapse as you need them or go to them...

Is there an effort underway to give the admin area some UI/UX love in that regard?

@tauriedavis ?

I think UX is working on this. @ernstvn see https://gitlab.com/gitlab-org/gitlab-ce/issues/28451

Awesome, thanks @annabeldunstone

Yes, it is on my priority list to improve settings. UX is pretty busy right now but we hope to roll out improvements each release.

Waiting from @mydigitalself to schedule.

removed frontend label

added Platform label

Related META issue: https://gitlab.com/gitlab-org/gitlab-ce/issues/34694

moved to gitlab#6628

Hey!

GitLab is moving all development for both GitLab Community Edition and Enterprise Edition into a single codebase. The current gitlab-ce repository will become a read-only mirror, without any proprietary code. All development is moved to the current gitlab-ee repository, which we will rename to just gitlab in the coming weeks. As part of this migration, issues will be moved to the current gitlab-ee project.

If you have any questions about all of this, please ask them in our dedicated FAQ issue.

https://gitlab.com/gitlab-org/gitlab-ee/issues/13855

You can also find more information here:

• https://gitlab.com/gitlab-org/gitlab-ee/issues/13304
• https://about.gitlab.com/2019/08/23/a-single-codebase-for-gitlab-community-and-enterprise-edition/

Frequently Asked Questions

For an up to date list of questions and answers, please take a look at https://gitlab.com/gitlab-org/gitlab-ee/issues/13855

What will we do with the repository names?

https://gitlab.com/gitlab-org/gitlab-ee/ will become https://gitlab.com/gitlab-org/gitlab, and https://gitlab.com/gitlab-org/gitlab-ce will become https://gitlab.com/gitlab-org/gitlab-foss.

Why rename gitlab-ce to gitlab-foss?

Using "gitlab" and "gitlab-ce" would be confusing, so we decided to rename gitlab-ce to gitlab-foss to make the purpose of this FOSS repository more clear

I created a merge requests for CE, and this got closed. What do I need to do?

You will need to create a merge request at https://gitlab.com/gitlab-org/gitlab-ee/. This link will eventually redirect to https://gitlab.com/gitlab-org/gitlab.

How does the licensing work in this new setup?

Everything in the ee/ directory is proprietary. Everything else is free and open source software. If your merge request does not change anything in the ee/ directory, the process of contributing changes is the same as when using the gitlab-ce repository.

Will you accept merge requests on the gitlab-ce/gitlab-foss project after it has been renamed?

No. Merge requests submitted to this project will be closed automatically.

Will I still be able to view old issues and merge requests in gitlab-ce/gitlab-foss?

Yes.

How will this affect users of GitLab CE using Omnibus?

No changes will be necessary, as the packages built remain the same.

How will this affect users of GitLab CE that build from source?

Once the project has been renamed, you will need to change your Git remotes to use this new URL. GitLab will take care of redirecting Git operations so there is no hard deadline, but we recommend doing this as soon as the projects have been renamed.

Where can I see a timeline of the remaining steps?

https://gitlab.com/gitlab-org/gitlab-ee/issues/13304

Will community contributions submitted to the new "gitlab" repository be available in the new gitlab-foss repository?

Yes, these changes will be synced to gitlab-foss automatically, several times per day.

locked this issue