Make it more obvious what Copy/Paste buttons are actually copying
Merge requests
-
Update text for reference
,personal access token
,URL
,commands
: !8535 (merged), https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/1048 -
Update text for commit SHA
: !8547 (merged), https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/1066
Description
Whenever I consider using one, I have to stop and think: "will this button actually copy what I want it to?" Then I usually end up just doing it by hand.
I think part of the confusion has to do with the placement of the button in relation to the content it will copy.
For example, in one case, we copy content to the right of the button, in another case we copy content not even touching the button, and in other cases, we copy content in the text box.
Proposed Solutions:
- Standardize our placement of the buttons and
- Display context (in the tooltip?) about what exactly will be copied
- Upon successfully copy, display what exactly has been copied
Here are some screenshots:
Screen_Shot_2016-10-20_at_11.54.13_AM Screen_Shot_2016-10-20_at_12.11.14_PM Screen_Shot_2016-10-20_at_12.13.16_PM Screen_Shot_2016-10-20_at_11.56.02_AM Screen_Shot_2016-10-20_at_12.31.53_PM
Design / What needs to be done?
link
Commit listTooltips should say: "Copy commit SHA to clipboard"
Commit View
Only when https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/6994 is merged!
The clipboard icon should have its tooltip changed to "Copy commit SHA to clipboard"
File Detail view
Personal access token
This should be updated with the tooltip: "Copy personal access token to clipboard"
should probably be on the side, because of viewport issues so:
MR Modals
It's about this modal window with the clipboard buttons:
Tooltip should say "Copy commands to clipboard" for each clipboard icon
Sidebar References
Important is that both tooltips need to be left positioned!
Tooltip should say: "Copy reference to clipboard"
Project Home
Tooltip should say: "Copy URL to clipboard"