Deprecation warning in migration
When running rake db:migrate on a fresh install, you get this warning:
== 20160819221833 ResetDiffNoteDiscussionIdBecauseItWasCalculatedWrongly: migrating
-- execute("UPDATE notes SET discussion_id = NULL WHERE discussion_id IS NOT NULL AND type = 'DiffNote'")
DEPRECATION WARNING: `#timestamps` was called without specifying an option for `null`. In Rails 5, this behavior will change to `null: false`. You should manually specify `null: true` to prevent the behavior of your existing migrations from changing. (called from block in change at /builds/gitlab-org/gitlab-ce/db/migrate/20160831214002_create_project_features.rb:13)We should make sure we know which we want to use and set it manually to ensure that Rails 5 doesn't mess up our migrations.
Maybe it's also worth considering setting config.active_support.deprecation = :raise to ensure that we aren't missing any deprecation warnings before upgrading to Rails 5.
cc: @stanhu