Failing spec: Diff notes resolve as authorized user multiple notes
From https://gitlab.com/winniehell/gitlab-ce/builds/5574703:
Diff notes resolve as authorized user multiple notes resolves discussion
Failure/Error: expect(page).to have_content('Resolved by')
expected to find text "Resolved by" in "Toggle navigation This project Go Brandy Weimann / project43 Toggle navigation Toggle navigation pinning Projects Todos 0 Activity Groups Milestones Issues 0 Merge Requests 0 Snippets Help Profile Settings Project Activity Repository Pipelines Graphs Issues 0 Merge Requests 1 Wiki Snippets Open Merge Request !1 opened about a minute ago by Madge Osinski CloseEdit Bug NS-04 Edited about a minute ago Check out branch Download as Request to merge master into feature (1 commit behind) Accept Merge Request Modify commit message You can also accept this merge request manually using the command line. Discussion 2 Commits 29 Changes 20 0/1 discussion resolved 0 0 Add Toggle discussion Leila Zulauf @georgette172 started a discussion on the diff about a minute ago Last updated by Dr. Vivienne Swift about a minute ago files/ruby/popen.rb 6 6 7 7 def popen(cmd, path=nil) 8 8 unless cmd.is_a?(Array) 9 raise \"System commands must be given as an array of strings\" 9 raise RuntimeError, \"System commands must be given as an array of strings\" 10 10 end 11 11 12 12 path ||= Dir.pwd 13 vars = { \"PWD\" => path } 14 options = { chdir: path } 13 14 vars = { Leila Zulauf @georgette172 commented about a minute ago Note Dr. Vivienne Swift @terrell173 commented about a minute ago Note Reply... Resolve discussion Write Preview Styling with Markdown and slash commands are supported Attach a file Close merge request Todo Add Todo Assignee Edit No assignee - assign yourself Milestone Edit None 2 participants Notifications Unsubscribe You're receiving notifications because you're subscribed to this thread. Reference: namespace43/gitlabhq!1"
# ./spec/features/merge_requests/diff_notes_resolve_spec.rb:218:in `block (4 levels) in <top (required)>'
Running ./spec/features/merge_requests/diff_notes_resolve_spec.rb
locally:
1) Diff notes resolve as authorized user multiple notes does not mark discussion as resolved when resolving single note
Failure/Error: expect(page).to have_content('0/1 discussion resolved')
expected to find text "0/1 discussion resolved" in "1/1 discussion resolved"
# ./spec/features/merge_requests/diff_notes_resolve_spec.rb:209:in `block (5 levels) in <top (required)>'
# ./spec/features/merge_requests/diff_notes_resolve_spec.rb:208:in `block (4 levels) in <top (required)>'
2) Diff notes resolve as authorized user multiple notes resolves discussion
Failure/Error: expect(page).to have_content('Resolved by')
expected to find text "Resolved by" in "Toggle navigation This project Go Hyman Reichel / project16 Toggle navigation Toggle navigation pinning Projects Todos 0 Activity Groups Milestones Issues 0 Merge Requests 0 Snippets Help Profile Settings Project Activity Repository Pipelines Graphs Issues 0 Merge Requests 1 Wiki Snippets Open Merge Request !1 opened less than a minute ago by Violet Gleichner CloseEdit Bug NS-04 Edited less than a minute ago Check out branch Download as Request to merge master into feature (1 commit behind) Accept Merge Request Modify commit message You can also accept this merge request manually using the command line. Discussion 1 Commits 29 Changes 20 0/1 discussion resolved 0 0 Add Toggle discussion Mrs. Kyleigh Gerhold @velda65 started a discussion on the diff less than a minute ago Last updated by Rodrigo Goldner less than a minute ago files/ruby/popen.rb 6 6 7 7 def popen(cmd, path=nil) 8 8 unless cmd.is_a?(Array) 9 raise \"System commands must be given as an array of strings\" 9 raise RuntimeError, \"System commands must be given as an array of strings\" 10 10 end 11 11 12 12 path ||= Dir.pwd 13 vars = { \"PWD\" => path } 14 options = { chdir: path } 13 14 vars = { Mrs. Kyleigh Gerhold @velda65 commented less than a minute ago Note Reply... Resolve discussion Write Preview Styling with Markdown and slash commands are supported Attach a file Close merge request Todo Add Todo Assignee Edit No assignee - assign yourself Milestone Edit None 2 participants Notifications Unsubscribe You're receiving notifications because you're subscribed to this thread. Reference: namespace16/gitlabhq!1"
# ./spec/features/merge_requests/diff_notes_resolve_spec.rb:218:in `block (4 levels) in <top (required)>'
3) Diff notes resolve as a guest someone elses merge request does not allow user to mark note as resolved
Failure/Error: first_note.diff_note?
ActionView::Template::Error:
undefined method `diff_note?' for nil:NilClass
# ./app/models/discussion.rb:63:in `diff_discussion?'
# ./app/models/discussion.rb:73:in `resolvable?'
# ./app/models/discussion.rb:79:in `resolved?'
# ./app/views/discussions/_headline.html.haml:1:in `_app_views_discussions__headline_html_haml___1406406633463130585_256902600'
# ./app/controllers/application_controller.rb:209:in `view_to_html_string'
# ./app/controllers/projects/discussions_controller.rb:22:in `unresolve'
# ./lib/gitlab/request_profiler/middleware.rb:15:in `call'
# ./lib/gitlab/middleware/go.rb:16:in `call'
# ./lib/gitlab/middleware/static.rb:9:in `call'
# ------------------
# --- Caused by: ---
# NoMethodError:
# undefined method `diff_note?' for nil:NilClass
# ./app/models/discussion.rb:63:in `diff_discussion?'