Custom error messages not displaying
Summary
When the hook returns an STDERR message upon a failure it should display on the merge request page. After the last stable release this stopped working. It now just leaves the "Merge in progress" button spinning forever. The backend returns the correct JSON string with message but there is a JS error on the page preventing it from displaying that there has been an error.
Steps to reproduce
- Create a hook that will fire and STDERR message upon failure
- Try to accept a merge request which fails upon a hook returning an STDERR output
Expected behavior
- Display the error message returned by STDERR
Actual behavior
- "Merge in progress" for ever
- JS error in console.
Relevant logs and/or screenshots
application-c38ee6c….js:23 Uncaught TypeError: Cannot read property 'html' of undefined
Results of GitLab environment info
System information
System:
Current User: git
Using RVM: no
Ruby Version: 2.3.1p112
Gem Version: 2.6.6
Bundler Version:1.13.5
Rake Version: 10.5.0
Sidekiq Version:4.2.1
GitLab information
Version: 8.13.1
Revision: 91f25c2
Directory: /opt/gitlab/embedded/service/gitlab-rails
DB Adapter: postgresql
URL: https://gitlab.xxx.com
HTTP Clone URL: https://gitlab.xxx.com/some-group/some-project.git
SSH Clone URL: git@gitlab.xxx.com:some-group/some-project.git
Using LDAP: yes
Using Omniauth: no
GitLab Shell
Version: 3.6.6
Repository storage paths:
- default: /var/opt/gitlab/git-data/repositories
Hooks: /opt/gitlab/embedded/service/gitlab-shell/hooks/
Git: /opt/gitlab/embedded/bin/git