Multiple simultaneous requests for an archive of the same repo/ref should use just one `git archive` process.

This locking is already supposed to happen, but appears to not be.

Do you have an idea on how to easily reproduce this? How do you detect that more than git archive process is being used?

@flevour There's a pidfile based lock in there: https://gitlab.com/gitlab-org/gitlab-ce/blob/master/app/services/archive_repository_service.rb It used to work, but apparently it doesn't anymore. I haven't looked into why.

@DouweM moving this up. Don't expect we'll do this in a patch.

Milestone changed to 8.1

@DouweM Will you be able to fix it in this milestone?. Or should I look at this?

@vsizov If you have time, please look into it!

Reassigned to @vsizov

@vsizov This may actually no longer be necessary if we have !1548 (merged).

mentioned in merge request !1548 (merged)

That's cool because I think that current implementation is not reliable anyway. It's not enough to just check if pid file exist, it should check whether the process id exist in the system now. Taking into account that systems like gitlab.com is distributed it makes a lot of problems. So, thanks @jacobvosmaer for the proper implementation.

Status changed to closed by commit 4b28f2d9

mentioned in commit 4b28f2d9