Accepting a merge request isn't obvious
Problem
I was also talking with a group that went through the merge request process for the first time and the process was a bit odd. The UX difficulty they had was realizing the button to accept the merge request would actually do it. Maybe this button isn’t obvious in terms of the wording it has?
The user thought something along the lines of “Yes, this merge looks good to me.” Not “Yes, I’d like to have this merged”. Perhaps a confirmation flow? Or maybe it would be useful to have a “thumbs up” type flow for everyone on the team as well as an “accept” flow to remove this confusion. The “thumbs up” flow would basically just let users voice that they approve these changes + list the users who have approved it.
Design specification
Change the button text simply fromAccept merge request
to Merge
as to make it clear exactly what action will happen when you click it.
Out of scope
The discussion thread below talks about displaying other information in the associated box. This will be worked in other issues. This issue is simply to change the button text to Merge
.