MR checking and accepting always run 'git gc' in backend satellite

I'm using Gitlab CE v7.8, we have a repository of about 1GB size and almost 100 developers working on it.

The problem I met is, when we submit merge request, or accept merge request, Gitlab response very slow for the process. I enabled the Grit debug log in

config/initializers/3_grit_ext.rb

Grit::debug = true

found that in satellite, every time execute git fetch, or git merge, it runs gc process:

Auto packing the repository for optimum performance. You may also
run "git gc" manually. See "git help gc" for more information.
warning: There are too many unreachable loose objects; run 'git prune' to remove them.

This gc process cost about 30s, and it is running every time on checking MR and accepting MR. When we got a log of MR to merge, this slows down the process.

GitLab no longer uses Grit and uses rugged instead. In 8.0, satellites will be removed completely, which should help your use case. I suggest upgrading to 7.14 at least to get the rugged performance improvements.

Hi @stanhu , thanks for you reply.

I checked 7-14-stable branch, found that the backend git merge process is still using Grit:

https://gitlab.com/gitlab-org/gitlab-ce/blob/7-14-stable/lib/gitlab/satellite/satellite.rb#L84

https://gitlab.com/gitlab-org/gitlab-ce/blob/7-14-stable/lib/gitlab/satellite/merge_action.rb#L132

If it's my misunderstanding, please tell me.

In 8.0, satellites will be removed completely

This is good news for me, I'll check it when 8.0 arrived.

Thanks!

Indeed, you are right. Grit does appear to still be used for satellites. @jacobvosmaer, could this be the mysterious cause of #2336 (closed)?

@stanhu no idea. Isn't this git gc in the satellite, not the 'real' repo?

@jacobvosmaer : yes, I confirm it is in the satellite.

@laputa thanks that makes sense.

The satellites are deprecated in 8.0, hopefully that will help.

Hi @laputa,

First of all, thank you for raising an issue to help improve the GitLab product. We're sorry about this, but this particular issue has gone unnoticed for quite some time. To establish order in the GitLab-CE Issue Tracker, we must ensure that every issue is correctly labelled and triaged, to get the proper attention.

This issue will be closed, as it meets the following criteria:

• No activity in the past 4 months
• Unlabelled
• Unassigned
• It's not associated with a particular milestone

We'd like to ask you to help us out and determine whether this issue should be reopened.

If this issue is reporting a bug, please can you attempt to reproduce on the latest version of GitLab or GitLab.com, to help us to understand whether the bug still needs our attention.

If this issue is proposing a new feature, please can you verify whether the feature proposal is still relevant.

Thanks for your help

Status changed to closed

Added ~761915 label

mentioned in merge request !14785