spinach test failure: Unable to find option "twitter_updated"

A number of Semaphore build failures are occurring (e.g. https://semaphoreci.com/gitlabhq/gitlabhq/branches/pull-request-9538/builds/18):

  Scenario: Update user identities
    ✔  Given I sign in as an admin                       # features/steps/shared/authentication.rb:11
    ✔  And system has users                              # features/steps/shared/admin.rb:8
    ✔  Given user "Pete" with twitter account            # features/steps/admin/users.rb:126
    ✔  And I visit "Pete" identities page in admin       # features/steps/admin/users.rb:131
    !  And I modify twitter identity                     # features/steps/admin/users.rb:140
    ~  Then I should see twitter details updated         

        Unable to find option "twitter_updated"
        /home/runner/gitlabhq/vendor/bundle/ruby/2.1.0/gems/capybara-2.4.4/lib/capybara/node/finders.rb:41:in `block in find'

Looking at the test, I'm not quite sure why the mock in features/steps/admin/users.rb is failing to provide the twitter_updated option. I can't seem to reproduce it by running bundle exec spinach features/admin/users.feature alone.

Interesting enough, if OmniAuth is enabled in gitlab.yml, all the tests fail with this error:

 No route matches {:action=>"passthru", :controller=>"omniauth_callbacks", :provider=>:twitter} missing required keys: [:provider]

I tried enabling OmniAuth.test_mode to no avail. Not sure what's going on here.

/cc: @DouweM

It looks like I can reproduce it on my machine if I run bundle exec rake spinach. I added debug statements, and it looks like the list of providers is empty when Admin::IdentitiesController is run.

I think there may be some threading issue here, where the mocked Devise providers are not affecting the Rails engine used by Capybara. I suspect we'll either have to move the mocking of the OAuth providers earlier or just disable this Spinach test outright.

mentioned in merge request !1272 (merged)

Status changed to closed by commit 32208c50

mentioned in commit 32208c50

mentioned in merge request !14785