Possible false positives in tests when storage is involved
It is possible that our automatic retry for RSpec test examples can lead to false positives:
See https://gitlab.com/gitlab-org/gitlab-ce/builds/6516592
HTML trace
when build has an initial trace
loads build trace
when build does not have an initial trace
2nd Try error in ./spec/features/projects/builds_spec.rb:199:
invalid base64
RSpec::Retry: 2nd try ./spec/features/projects/builds_spec.rb:199
loads new trace
This was a test example which should fail, because I created a test first, then was working on the fix. I wanted to see failure in CI, but the test passed.
This was a part of https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/7658