mail notifications (from issues) are sent twice

My mail notifications for subscribed issues on gitlab.com are sent twice to me. It started yesterday for the issue #2164 (closed) for the comments:

• https://gitlab.com/gitlab-org/gitlab-ce/issues/2164#note_2129286

and

• https://gitlab.com/gitlab-org/gitlab-ce/issues/2164#note_2129101

Can anyone reproduce this If necessary I can of course post the complete mail header!

I can confirm the issue.

Steps to reproduce:

• go to issue, hit "Subscribe" button
• find something to say and write a comment
• you will now receive doubled notifications

The issue seems to be in NotificationService. Subscribed and participated users added to a list of users to be notified. Perhaps trivial recipients = recipients.uniq will do the job here.

I will try to add the tests and make the MR out of it.

mentioned in merge request !1925 (merged)

Status changed to closed by commit caa6851b

mentioned in commit caa6851b

mentioned in commit e2c57a41

mentioned in merge request !14785