Store information about build retry in the database

Description

Checking if the build was retried is time consuming operation.

Proposal

Storing information about build retry in the database may improve performance.

Idea from @ayufan during Slack conversation :)

/cc @ayufan

cc/ @yorickpeterse

@grzesiek: I have no idea specifically what we check and what we need to store. Could you elaborate on this?

@yorickpeterse We check if build was retried in quite a few places. Currently to know whether the build was retried, we have to load all pipeline builds and see if there is another similar build in the same stage. This means that we have to execute a lot of queries each time we want to show list of builds in the pipeline with appropriate icon next to builds that were retried.

Ci::Pipeline.latest scope that defines most recent builds, excluding retried ones

  scope :latest, -> do
    max_id = unscope(:select).select("max(#{quoted_table_name}.id)")

    where(id: max_id.group(:name, :commit_id))
  end

CommitStatus#retried?

def retried?
  !self.pipeline.statuses.latest.include?(self)
end

A build can be retried multiple times, so it is one-to-many relationship, but in most cases we only need to know if build was retried. Simple solution may be adding ci_builds.retried boolean field and build_retried table to track retries, but the latter may not be necessary at this point.

mentioned in issue #30701 (closed)

changed milestone to %9.2

added Deliverable label

mentioned in merge request !10584 (merged)

assigned to @ayufan

mentioned in merge request !10721 (closed)

mentioned in issue #31146 (moved)

mentioned in merge request !11115 (merged)

closed via merge request !11115 (merged)

mentioned in commit 0e175cf9