Broken image when doing offline update check (Help page)

Description

Without internet access, the Update Check on the Help page shows a broken image:

I'd say 404'd image, but the Chrome Inspector shows (failed) Status on Network tab, and net::ERR_CONNECTION_TIMED_OUT on Console tab.

Proposal

Also make it pretty when Update Check fails.

added frontend ~12980 ~131895 labels

Is there a way to assign this issue to myself?

@gamesover I've assigned you now. Please mention this issue in the associated Merge Request that you create

assigned to @gamesover

mentioned in merge request !8355 (merged)

I am a bit confused about

Also make it pretty when Update Check fails.

It looks it needs to fetch image from gitlab.com with hashed current version, if internet is broken, you can never know whether current version is updated or not. How can I make it pretty?

It looks like we're planning some changes in this area. I think the improvements proposed in the following issue will remove this problem:

• https://gitlab.com/gitlab-org/gitlab-ce/issues/14381

added ~123454 label

@markglenfletcher , thanks very much for your info.

To sum up the two issues, I can see:

1. the current update check in help page shall be removed
2. What's new? function shall be added to replace the current version check in help page.

I am not sure whether you usually will open a new story for What's new? function since #14381 (moved) title is Remove update label from help . So may I ask what's the current issue scope? To remove the update label in help page? Or add the What's new? function in Profile dropdown?

To my opinion, it is better to separate the two parts, one ticket to remove current version check in help page, and the other ticket to add What's new? function. Also, the ticket title shall reflect the actual #14381 (moved) purpose, Remove update label from help seems not quite appropriate, or maybe there will be a new improvement story opened?

The last thing, yes, if the #14381 (moved) is completely implemented, the current issue will be obsolete.

cc @tauriedavis , @dimitrieh

Thanks @gamesover !

The discussion for What's new was out of scope for https://gitlab.com/gitlab-org/gitlab-ce/issues/14381 and was moved to https://gitlab.com/gitlab-org/gitlab-ce/issues/25341.

For https://gitlab.com/gitlab-org/gitlab-ce/issues/14381, we would like the update message to change depending on whether the user is an admin or not.

- For admins we want to show the current messages: Up to date, New version available, Update ASAP
- For non-admins we want to show only the first two messages: Up to date, New version available

The original proposal was to remove the update message but we decided against this so I believe this issue is still needed. I've updated the title https://gitlab.com/gitlab-org/gitlab-ce/issues/14381 to reflect this.

closed via merge request !8355 (merged)