LATEST_TAG variable in patch update guide is set to rc version

When I updated from 7.14.1 to 7.14.3 two days ago (following the patch update guide ), the LATEST_TAG variable was set to v8.0.0.rc1. I manually used v7.14.3 instead because I don't want to install an rc version.

Is that intended behaviour? I don't think users expect to update to a new major version, especially not when following a patch update guide.

cc @axil

Oops didn't think of that case. Should we revert and maybe leave that command as a comment?

@axil maybe we can change the command a bit to use
git tag -l <pattern>
see http://stackoverflow.com/questions/1064499/how-to-get-a-list-of-all-git-tags

ah the command you used has a pattern flag as well :)
--match <pattern>
So we can add that right?
http://git-scm.com/docs/git-describe

git tag -l 'v*.[0-9]' --sort='v:refname' seems like a good list to me. I'm not sure if it contains tags where the last number has more than one digit though.

the patch releases shouldn't go into high numbers, so that should be ok.

If we want to exclude the rc files we can just pipe it to grep -v rc. I'm not sure how to handle the case of not jumping in major versions.

I think that the patch guide was created for users that are already on the latest stable version. You shoudn't follow this guide for upgrades to major versions.

Another hack I can think of is to parse the VERSION file and filter the tags according to that.

Maybe it's enough to just print the current version in addition to the tag list and add a comment for users to be careful not to upgrade to a new major/minor version.

https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/1510

@kloolk MR has been merged, so I'll close this issue.

Status changed to closed

Mentioned in commit pfjason/gitlab-ce@cde076c5

mentioned in merge request !14785