Skip to content

Users admin area - Sort by Recent Sign-in does not sort correctly

Summary

Users admin area - Sort by Recent Sign-in does not sort correctly. There are two errors:

  1. Users who have never signed in are listed first rather than last
  2. Users with older Current Sign-in Date are appearing ahead of users with newer Current Sign-in date (may just be an issue for logged in administrator)

Steps to reproduce

  1. Add a new user and sort by Recent Sign-in. The new user will appear at the top of the list rather than the bottom of the list.
  2. No steps required. As administrator you should appear at the top of a Sort by Recent Sign-in list. If not, you have reproduced this error.

Expected behavior

Sort by Recent Sign-in immediately following an administrator login should show the administrator first and people who have never logged in last.

Actual behavior

People who have never logged in appear at the top of the list. As administrator I was not at the top of the list even though my Current Sign-in Date was newer than people ahead of me in the sorted list.

Relevant logs and/or screenshots

None

Output of checks

None

Results of GitLab application Check

GitLab Shell version >= 4.1.1 ? ... OK (4.1.1)
Repo base directory exists?
default... yes
Repo storage directories are symlinks?
default... no
Repo paths owned by git:git?
default... yes
Repo paths access is drwxrws---?
default... yes
hooks directories in repos are links: ...
3/1 ... ok
5/2 ... ok
3/6 ... ok
3/8 ... ok
3/9 ... ok
3/10 ... ok
3/11 ... ok
3/13 ... ok
3/14 ... ok
6/15 ... ok
3/16 ... ok
5/18 ... ok
31/27 ... ok
31/28 ... ok
28/38 ... ok
28/40 ... ok
4/41 ... ok
28/43 ... ok
28/45 ... ok
30/47 ... repository is empty
31/48 ... ok
28/55 ... ok
36/58 ... ok
5/59 ... ok
5/60 ... repository is empty
2/68 ... ok
21/71 ... ok
4/72 ... ok
42/75 ... ok
28/76 ... ok
46/78 ... ok
28/80 ... ok
46/85 ... ok
47/90 ... ok
52/92 ... ok
53/93 ... ok
45/94 ... ok
46/98 ... ok
55/99 ... ok
59/100 ... ok
5/101 ... ok
5/104 ... ok
61/106 ... ok
60/107 ... ok
29/108 ... ok
64/111 ... ok
69/113 ... ok
55/115 ... ok
60/119 ... ok
28/122 ... ok
46/124 ... ok
5/126 ... ok
5/129 ... ok
28/130 ... ok
28/131 ... ok
Running /opt/gitlab/embedded/service/gitlab-shell/bin/check
Check GitLab API access: OK
Access to /var/opt/gitlab/.ssh/authorized_keys: OK
Send ping to redis server: OK
gitlab-shell self-check successful
Checking GitLab Shell ... Finished
Checking Sidekiq ...
Running? ... yes
Number of Sidekiq processes ... 1
Checking Sidekiq ... Finished
Checking Reply by email ...
Reply by email is disabled in config/gitlab.yml
Checking Reply by email ... Finished
Checking LDAP ...
LDAP is disabled in config/gitlab.yml
Checking LDAP ... Finished
Checking GitLab ...
Git configured with autocrlf=input? ... yes
Database config exists? ... yes
All migrations up? ... yes
Database contains orphaned GroupMembers? ... no
GitLab config exists? ... yes
GitLab config outdated? ... no
Log directory writable? ... yes
Tmp directory writable? ... yes
Uploads directory setup correctly? ... no
  Try fixing it:
  sudo chown -R git /var/opt/gitlab/gitlab-rails/uploads
  sudo find /var/opt/gitlab/gitlab-rails/uploads -type f -exec chmod 0644 {} \;
  sudo find /var/opt/gitlab/gitlab-rails/uploads -type d -not -path /var/opt/gitlab/gitlab-rails/uploads -exec chmod 0700 {} \;
  For more information see:
  doc/install/installation.md in section "GitLab"
  Please fix the error above and rerun the checks.
Init script exists? ... skipped (omnibus-gitlab has no init script)
Init script up-to-date? ... skipped (omnibus-gitlab has no init script)
projects have namespace: ...
3/1 ... yes
5/2 ... yes
3/6 ... yes
3/8 ... yes
3/9 ... yes
3/10 ... yes
3/11 ... yes
3/13 ... yes
3/14 ... yes
6/15 ... yes
3/16 ... yes
5/18 ... yes
31/27 ... yes
31/28 ... yes
28/38 ... yes
28/40 ... yes
4/41 ... yes
28/43 ... yes
28/45 ... yes
30/47 ... yes
31/48 ... yes
28/55 ... yes
36/58 ... yes
5/59 ... yes
5/60 ... yes
2/68 ... yes
21/71 ... yes
4/72 ... yes
42/75 ... yes
28/76 ... yes
46/78 ... yes
28/80 ... yes
46/85 ... yes
47/90 ... yes
52/92 ... yes
53/93 ... yes
45/94 ... yes
46/98 ... yes
55/99 ... yes
59/100 ... yes
5/101 ... yes
5/104 ... yes
61/106 ... yes
60/107 ... yes
29/108 ... yes
64/111 ... yes
69/113 ... yes
55/115 ... yes
60/119 ... yes
28/122 ... yes
46/124 ... yes
5/126 ... yes
5/129 ... yes
28/130 ... yes
28/131 ... yes
Redis version >= 2.8.0? ... yes
Ruby version >= 2.1.0 ? ... yes (2.3.3)
Your git bin path is "/opt/gitlab/embedded/bin/git"
Git version >= 2.7.3 ? ... yes (2.8.4)
Active users: 57

Results of GitLab environment info

System information
System:         Debian 7.8
Current User:   git
Using RVM:      no
Ruby Version:   2.3.3p222
Gem Version:    2.6.6
Bundler Version:1.13.6
Rake Version:   10.5.0
Sidekiq Version:4.2.7

GitLab information
Version:        8.15.1
Revision:       1119c1f
Directory:      /opt/gitlab/embedded/service/gitlab-rails
DB Adapter:     postgresql
Using LDAP:     no
Using Omniauth: no

GitLab Shell
Version:        4.1.1
Repository storage paths:
- default:      /var/opt/gitlab/git-data/repositories
Hooks:          /opt/gitlab/embedded/service/gitlab-shell/hooks/
Git:            /opt/gitlab/embedded/bin/git

Possible fixes