Admin console permits negative attachment size
Summary: The admin page permitted me to inadvertently set a negative value for maximum attachment size.
Steps to Reproduce: Go to admin page (/admin/application_settings). Change maximum attachment size to -10. Save. Then, try to make a comment on a merge request. It will fail with a 500.
Expected behavior: Page-level validation error saying that negative values for maximum attachment size are not allowed.
Observed behavior: Save of settings worked. Subsequently, it was not possible to make comments on merge requests.
GitLab 8.0 - d70c051d
Activity
Hi @goddardcm,
First of all, thank you for raising an issue to help improve the GitLab product. We're sorry about this, but this particular issue has gone unnoticed for quite some time. To establish order in the GitLab-CE Issue Tracker, we must ensure that every issue is correctly labelled and triaged, to get the proper attention.
This issue will be closed, as it meets the following criteria:
- No activity in the past 4 months
- Unlabelled
- Unassigned
- It's not associated with a particular milestone
We'd like to ask you to help us out and determine whether this issue should be reopened.
If this issue is reporting a bug, please can you attempt to reproduce on the latest version of GitLab or GitLab.com, to help us to understand whether the bug still needs our attention.
If this issue is proposing a new feature, please can you verify whether the feature proposal is still relevant.
Thanks for your help
-
@goddardcm This is no longer reproducible in 8.11.x. The validation against negative attachment size has since been introduced
. mentioned in merge request !14785
