Insecure content in JIRA integration
Summary
If using HTTPS in JIRA, Chrome will display Insecure Content warnings when a merge request is merged. This is because the following image is added under the "Issue Links": http://www.openwebgraphics.com/resources/data/1768/16x16_apply.png
Steps to reproduce
- Ensure JIRA is running under HTTPS
- Link MR with a JIRA issue
- Merge the MR
- Notice a green ticket is added under "Issue Links" - "Gitlab: Issue Solved by... "
Expected behavior
Should use HTTPS.
Actual behavior
Loads image via HTTP.
Relevant logs and/or screenshots
n/a
Output of checks
n/a
Results of GitLab application Check
n/a
Results of GitLab environment info
n/a
Possible fixes
Specify URL as protocol independent: //www.openwebgraphics.com/resources/data/1768/16x16_apply.png
https://github.com/gitlabhq/gitlabhq/blob/master/app/models/project_services/jira_service.rb#L264