Comment and Comment+close buttons are too close

Description

I have a kind of slippery desk and sometimes the mouse slips while I want to click on Comment, but I click on Comment+close. As there are no warning before doing the action, I close the issue, and I have to open it again, but the notification has been sent to everyone already.

Updated Proposal

There is another issue to tackle rearranging the order of buttons (primary buttons placed to the right. For this particular case, we should implement a confirmation modal for Comment+close.

Original Proposal

• Investigate whether this is a problem
• If it is, let's change the position of the Comment+close button.

Links / references

https://gitlab.com/gitlab-org/gitlab-ce/issues/26248

cc @sarahod @awhildy

@tauriedavis - has you heard this concern come up before? Thoughts?

I haven't heard of this specific case being an issue (although I can see how it could be). It goes back to the ordering of our buttons and I think https://gitlab.com/gitlab-org/gitlab-ce/issues/26248 would help to fix this problem (place primary button to the right).

We are moving ahead with re-ordering the buttons in confirmation dialogs https://gitlab.com/gitlab-org/gitlab-ce/issues/28849 and https://gitlab.com/gitlab-org/gitlab-ce/issues/26248 has been slated for the next 2-3 months.

I would suggest that we add a confirmation modal to close out the comment, especially if we are switching the button positions.

added UX and removed UX research labels

changed the description

I think a confirmation could get annoying in this case. It's not a destructive action, since you can easily reopen the issue if you make a mistake.

It would be nice to see data on how often an issue is closed and immediately reopened, and compare that with data after we reorder the buttons. I'm not sure if piwik could tell us this or not, but we would know if reordering helped the problem and also if this was a common enough mistake to warrant adding a confirmation.

moved to gitlab#8064

Hey!

GitLab is moving all development for both GitLab Community Edition and Enterprise Edition into a single codebase. The current gitlab-ce repository will become a read-only mirror, without any proprietary code. All development is moved to the current gitlab-ee repository, which we will rename to just gitlab in the coming weeks. As part of this migration, issues will be moved to the current gitlab-ee project.

If you have any questions about all of this, please ask them in our dedicated FAQ issue.

https://gitlab.com/gitlab-org/gitlab-ee/issues/13855

You can also find more information here:

• https://gitlab.com/gitlab-org/gitlab-ee/issues/13304
• https://about.gitlab.com/2019/08/23/a-single-codebase-for-gitlab-community-and-enterprise-edition/

Frequently Asked Questions

For an up to date list of questions and answers, please take a look at https://gitlab.com/gitlab-org/gitlab-ee/issues/13855

What will we do with the repository names?

https://gitlab.com/gitlab-org/gitlab-ee/ will become https://gitlab.com/gitlab-org/gitlab, and https://gitlab.com/gitlab-org/gitlab-ce will become https://gitlab.com/gitlab-org/gitlab-foss.

Why rename gitlab-ce to gitlab-foss?

Using "gitlab" and "gitlab-ce" would be confusing, so we decided to rename gitlab-ce to gitlab-foss to make the purpose of this FOSS repository more clear

I created a merge requests for CE, and this got closed. What do I need to do?

You will need to create a merge request at https://gitlab.com/gitlab-org/gitlab-ee/. This link will eventually redirect to https://gitlab.com/gitlab-org/gitlab.

How does the licensing work in this new setup?

Everything in the ee/ directory is proprietary. Everything else is free and open source software. If your merge request does not change anything in the ee/ directory, the process of contributing changes is the same as when using the gitlab-ce repository.

Will you accept merge requests on the gitlab-ce/gitlab-foss project after it has been renamed?

No. Merge requests submitted to this project will be closed automatically.

Will I still be able to view old issues and merge requests in gitlab-ce/gitlab-foss?

Yes.

How will this affect users of GitLab CE using Omnibus?

No changes will be necessary, as the packages built remain the same.

How will this affect users of GitLab CE that build from source?

Once the project has been renamed, you will need to change your Git remotes to use this new URL. GitLab will take care of redirecting Git operations so there is no hard deadline, but we recommend doing this as soon as the projects have been renamed.

Where can I see a timeline of the remaining steps?

https://gitlab.com/gitlab-org/gitlab-ee/issues/13304

Will community contributions submitted to the new "gitlab" repository be available in the new gitlab-foss repository?

Yes, these changes will be synced to gitlab-foss automatically, several times per day.

locked this issue