Skip to content
Snippets Groups Projects

Merge request: Accept button shows even when approvals are required

Summary

A merge request requires at least one approval, but the "Accept Merge Request" button still shows, and the merge request says it was approved by no one.

Steps to reproduce

Create a new merge request that requires at least one approval. Go to the merge request page.

Expected behavior

The "Accept Merge Request" button should be disabled or removed from the page entirely.

Actual behavior

The "Accept Merge Request" button can be clicked, which results in a 404 and a "Something went wrong on our end" message.

Relevant logs and/or screenshots

image

Output of checks

Results of GitLab application Check

$ sudo -u gitlab -H bundle exec rake gitlab:check RAILS_ENV=production SANITIZE=true
Checking GitLab Shell ...

GitLab Shell version >= 4.1.1 ? ... OK (4.1.1)
Repo base directory exists?
default... yes
Repo storage directories are symlinks?
default... no
Repo paths owned by gitlab:gitlab?
default... yes
Repo paths access is drwxrws---?
default... yes
hooks directories in repos are links: ... 
4/1 ... ok
2/2 ... ok
2/3 ... ok
2/4 ... ok
2/5 ... ok
2/6 ... ok
2/7 ... ok
2/8 ... ok
2/9 ... ok
2/10 ... ok
2/11 ... ok
Running /usr/share/webapps/gitlab-shell/bin/check
Check GitLab API access: OK
Access to /var/lib/gitlab/.ssh/authorized_keys: OK
Send ping to redis server: OK
gitlab-shell self-check successful

Checking GitLab Shell ... Finished

Checking Sidekiq ...

Running? ... yes
Number of Sidekiq processes ... 1

Checking Sidekiq ... Finished

Checking Reply by email ...

Reply by email is disabled in config/gitlab.yml

Checking Reply by email ... Finished

Checking LDAP ...

LDAP is disabled in config/gitlab.yml

Checking LDAP ... Finished

Checking GitLab ...

Git configured with autocrlf=input? ... yes
Database config exists? ... yes
All migrations up? ... yes
Database contains orphaned GroupMembers? ... no
GitLab config exists? ... yes
GitLab config outdated? ... no
Log directory writable? ... yes
Tmp directory writable? ... yes
Uploads directory setup correctly? ... yes
Init script exists? ... no
  Try fixing it:
  Install the init script
  For more information see:
  doc/install/installation.md in section "Install Init Script"
  Please fix the error above and rerun the checks.
Init script up-to-date? ... can't check because of previous errors
projects have namespace: ... 
4/1 ... yes
2/2 ... yes
2/3 ... yes
2/4 ... yes
2/5 ... yes
2/6 ... yes
2/7 ... yes
2/8 ... yes
2/9 ... yes
2/10 ... yes
2/11 ... yes
Redis version >= 2.8.0? ... yes
Ruby version >= 2.1.0 ? ... yes (2.3.3)
Your git bin path is "/usr/bin/git"
Git version >= 2.7.3 ? ... yes (2.11.0)
Active users: 8

Checking GitLab ... Finished

I believe the failing test related to the init script is because I have Gitlab installed on an Arch linux server, and the init is managed by systemd.

Results of GitLab environment info

$ sudo -u gitlab -H bundle exec rake gitlab:env:info RAILS_ENV=production

System information
System:		
Current User:	gitlab
Using RVM:	no
Ruby Version:	2.3.3p222
Gem Version:	2.5.2
Bundler Version:1.13.7
Rake Version:	10.5.0
Sidekiq Version:4.2.7

GitLab information
Version:	8.16.2-ee
Revision:	fatal: Not a git repository (or any of the parent directories): .git
Directory:	/usr/share/webapps/gitlab
DB Adapter:	PostgreSQL
DB Version:	9.6.1
URL:		https://gitlab.myfarms.com
HTTP Clone URL:	https://gitlab.myfarms.com/some-group/some-project.git
SSH Clone URL:	gitlab@gitlab.myfarms.com:some-group/some-project.git
Elasticsearch:	no
Geo:		no
Using LDAP:	no
Using Omniauth:	yes
Omniauth Providers: github, gitlab, google_oauth2

GitLab Shell
Version:	4.1.1
Repository storage paths:
- default: 	/var/lib/gitlab/repositories/
Hooks:		/usr/share/webapps/gitlab-shell/hooks/
Git:		/usr/bin/git