Different avatars in the UI

Summary

GL is pulling avatar from the user setting only for issues/MRs - commit messages are pulling gravatar from primary email:

Steps to reproduce

See https://gitlab.com/gitlab-com/www-gitlab-com/merge_requests/4898/pipelines?diff_id=2819696&start_sha=aa2f477ee0369b5e7c20ab037df5613374e72040 for instance

What is the current bug behavior?

Wrong avatar displayed for commit messages / 2 different avatars to 1 user

What is the expected correct behavior?

Same avatar for everything

Relevant logs and/or screenshots

above

Output of checks

This bug happens on GitLab.com, not sure if it happens on CE/EE

Results of GitLab environment info

n/a

Results of GitLab application Check

n/a

(we will only investigate if the tests are passing)

Possible fixes

Pull user avatar for every event

cc/ @awhildy

Thanks @marcia! Agreed - should be the same avatar everywhere.

@jschatz1 Ideas on what is going on here?

added frontend and removed ~19492 labels

@awhildy yes :)

@grzesiek can you please take a look?

added ~901060 and removed frontend labels

added ~19173 label

mentioned in issue #28002 (closed)

@filipa We probably should refine our API and related frontend code, because current implementation is error prone.

@grzesiek I agree, can we close this one in favor of #28096 (closed) ?

mentioned in issue #28081 (closed)

@filipa I'm not completely sure if this are the same issues. This one says about misused avatars, the other one says about different users being presented. Can we check if we indeed show different avatars even if user is the same?

Noticing this issue in header. Header shows different avatar than elsewhere. Screenshot is from profile view.

The avatars on the pipelines page are also wrong: https://gitlab.com/gitlab-org/gitlab-ce/pipelines

Here is a screenshot of a private project - all users have only one configured email address and author/commitor are the same:

mentioned in issue #28623 (closed)

mentioned in issue #29067 (closed)

changed milestone to %9.2

added Stretch label

mentioned in issue #31405 (closed)

Why is this ~CI

This is because the commit email is not the same as the user email I suspect. In which case its working as expected?

We use author image either from e-mail or user profile. In places where we show commit we use author from e-mail. Should we instead use the one from user profile @DouweM?

@ayufan If there is a matching user for the commit email, we should link to the user profile and show the user avatar. If not, we should link to mailto:<email> and show the gravatar. See AvatarHelper.

It looks like the pipeline list is currently not doing this, since it shows the gravatar and mailto link, while the commit page at https://gitlab.com/gitlab-com/www-gitlab-com/commit/a7e22f7a2116f033e89c1b9ddb92fb4ddfedd975 shows the user avatar and profile link.

@filipa @selfup Do you remember how we render that for Pipeline list? Do we have a CommitAuthor object for VueJS? Previously we would use AvatarHelper (when written in haml), but I don't think that we do it now.

changed milestone to %9.3

@ayufan it will hopefully be fixed with this MR: https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/10718

@filipa Is that fixed then?

It should have been fixed in here: https://gitlab.com/gitlab-org/gitlab-ce/commit/228b73d5e9e68991017dbfc5d072c3831411c383

@ayufan @DouweM what is happening on the frontend with the vue.js user avatar component is:

• If an avatar_url is provided to the component, we render it
• If no avatar_url is provided to the component, we render the default icon.

1. On the pipelines table only - to show the commit author, there is some extra logic: https://gitlab.com/gitlab-org/gitlab-ce/blob/master/app/assets/javascripts/vue_shared/components/pipelines_table_row.js#L62

• if there is a commit.author author and an author avatar_url, show avatar_url
• if there is a commit.author author and no author avatar_url, show gravatar_url instead
• if there is no commit.author show gravatar_url and link to mailto:author_email

which according to this comment is correct: https://gitlab.com/gitlab-org/gitlab-ce/issues/28003#note_29698602

Question Should logic of point 1. be present in environments table? It is not.

@filipa Since it's showing gravatar and mailto:, following your logic it seems like there is no commit.author...

/cc @ayufan

@DouweM the code was changed after this issue was created, it might have been fixed meanwhile :)

The correct avatar is displayed on the 'activity' view of the project while on the 'commits' view it shows some dummy graphics. The same dummy graphics is displayed when viewing specific commit.

- activity view - commits view - specific commit view

I think the regression was introduced when moving to GitLab 9.X

@meirtsvi That's an unrelated issue, and has to do with the fact that the user who pushes a commit is always a user known to GitLab, since they authenticate over HTTP or SSH. The author of the actual commit, however, is not necessarily the same user, and we look them up based on email address. If the commit author email does not match any GitLab user's email address, we will not show their avatar with the commit, and will not link to their profile.

Thanks @DouweM it was indeed this issue.

changed milestone to %9.4

changed milestone to %Backlog

removed Stretch label

moved to gitlab#8254

Hey! 👋

GitLab is moving all development for both GitLab Community Edition and Enterprise Edition into a single codebase. The current gitlab-ce repository will become a read-only mirror, without any proprietary code. All development is moved to the current gitlab-ee repository, which we will rename to just gitlab in the coming weeks. As part of this migration, issues will be moved to the current gitlab-ee project.

If you have any questions about all of this, please ask them in our dedicated FAQ issue.

https://gitlab.com/gitlab-org/gitlab-ee/issues/13855

You can also find more information here:

• https://gitlab.com/gitlab-org/gitlab-ee/issues/13304
• https://about.gitlab.com/2019/08/23/a-single-codebase-for-gitlab-community-and-enterprise-edition/

Frequently Asked Questions

For an up to date list of questions and answers, please take a look at https://gitlab.com/gitlab-org/gitlab-ee/issues/13855

What will we do with the repository names?

https://gitlab.com/gitlab-org/gitlab-ee/ will become https://gitlab.com/gitlab-org/gitlab, and https://gitlab.com/gitlab-org/gitlab-ce will become https://gitlab.com/gitlab-org/gitlab-foss.

Why rename gitlab-ce to gitlab-foss?

Using "gitlab" and "gitlab-ce" would be confusing, so we decided to rename gitlab-ce to gitlab-foss to make the purpose of this FOSS repository more clear

I created a merge requests for CE, and this got closed. What do I need to do?

You will need to create a merge request at https://gitlab.com/gitlab-org/gitlab-ee/. This link will eventually redirect to https://gitlab.com/gitlab-org/gitlab.

How does the licensing work in this new setup?

Everything in the ee/ directory is proprietary. Everything else is free and open source software. If your merge request does not change anything in the ee/ directory, the process of contributing changes is the same as when using the gitlab-ce repository.

Will you accept merge requests on the gitlab-ce/gitlab-foss project after it has been renamed?

No. Merge requests submitted to this project will be closed automatically.

Will I still be able to view old issues and merge requests in gitlab-ce/gitlab-foss?

Yes.

How will this affect users of GitLab CE using Omnibus?

No changes will be necessary, as the packages built remain the same.

How will this affect users of GitLab CE that build from source?

Once the project has been renamed, you will need to change your Git remotes to use this new URL. GitLab will take care of redirecting Git operations so there is no hard deadline, but we recommend doing this as soon as the projects have been renamed.

Where can I see a timeline of the remaining steps?

https://gitlab.com/gitlab-org/gitlab-ee/issues/13304

Will community contributions submitted to the new "gitlab" repository be available in the new gitlab-foss repository?

Yes, these changes will be synced to gitlab-foss automatically, several times per day.

locked this issue