500 error when clicking on integrations

https://sentry.gitlap.com/gitlab/gitlabcom/issues/20089/

NotImplementedError: NotImplementedError
  app/models/service.rb:83:in `to_param'
    raise NotImplementedError
  app/models/service.rb:79:in `to_param'
    self.class.to_param
  app/models/project.rb:845:in `block in find_service'
    list.find { |service| service.to_param == name }
  app/models/project.rb:845:in `find_service'
    list.find { |service| service.to_param == name }
  lib/gitlab/metrics/instrumentation.rb:155:in `block in find_service'
    trans.method_call_for(#{label.to_sym.inspect}).measure { super }
...
(113 additional frame(s) were not displayed)

NotImplementedError: NotImplementedError

@markglenfletcher

Associated issue: https://gitlab.com/gitlab-com/support-forum/issues/1535

These issues started showing up in Sentry on the 9th Feb.

/cc @felipe_artur

added ~480950 services labels

/cc @jivanvl

/cc @tiagonbotelho

added regression label

changed milestone to %9.0

mentioned in issue #27926 (closed)

Note: This happens for https://gitlab.com/gitlab-org/gitlab-ce/settings/integrations as well!

added reproduced on GitLab.com label

It appears that chatopts classes do not have to_param implemented. Is this possible that this is a culprit? What do you think @zj? This commit https://gitlab.com/gitlab-org/gitlab-ce/commit/4b6e583ce0a395ec4a0dbc1a3a81680b1a0aa700 added the exception. /cc @tiagonbotelho

I'm a bit confused by the milestone, Ill set it to this release. @grzesiek I'll dig into this today, and update here my findings. Hopefully get a MR in today too, so this can be fixed in the next RC

changed milestone to %8.17

assigned to @zj

@zj The milestone follows the process described here: https://about.gitlab.com/handbook/engineering/workflow/#choosing-something-to-work-on (I think?).

@rymai I haven't read that section for a while, for to me it signalled that we are going to fix it only in 9.0?

The milestone to me signals in what release it should be included, in this case 8.17, with MRs I would label it Pick into Stable and 8.17.

changed milestone to %9.0

@zj There was a related conversation in Slack (https://gitlab.slack.com/archives/releases/p1486654117005701), pasting here for external purposes:

mark [8:58 PM] Is it still procedure to mark regression issues with next release milestone (9.0, at the moment)? Just wondering if this has changed with the new release cycles (edited)

jameslopez [9:01 PM] AFAIK we still do that, yes /cc @douwe

douwe [9:02 PM] @mark @jameslopez Yep, we still do that. The issue milestone is always the development month, which runs from the 7th to the 6th, and is currently 9.0

[9:02]
The merge request milestone is always the release it should go into, which is not always the same as the development month

At the time I think the problem is a project where GitlabCiService is created. Given this can be safely removed, and its deprecated, Ill create a MR to do just that.

@markglenfletcher Confusing that those are different. I don't see why we can't apply the same for issues.

mentioned in merge request !9221 (merged)

I might've been my fault since I applied those changes in https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/8324 and I might've failed to update a Service since there were so many. Any more help needed just ping me!

mentioned in issue gitlab-com/support-forum#1535

closed via merge request !9221 (merged)

changed title from NotImplementedError: NotImplementedError to 500 error when clicking on integrations

mentioned in commit f0035f89

@tiagonbotelho I had another report from a customer using 9.1 do you think it could be another service that needs updating?

Ref: https://gitlab.zendesk.com/agent/tickets/74519

mentioned in issue #31481 (closed)

mentioned in issue #31502 (closed)

I see this is closed but is it still an issue? I'm getting this on new projects with GitLab CE v9.1.2

---

What I Did

[1] Logged in and created a new project [2] Clicked "Settings" then "Integrations" menu item

---

What I Expected To See

I'm following this guide:

https://gitlab.com/help/user/project/integrations/slack.md

There should be a page where you can set up a new integration and see this sort of thing

https://gitlab.com/help/user/project/integrations/img/slack_configuration.png

---

What I Saw

A custom GitLab 500 error page with "Whoops, something went wrong on our end."

Logged error:

Processing by Projects::Settings::IntegrationsController#show as HTML
 Parameters: {“namespace_id”=>“blinkmobile”, “project_id”=>“simple-analytics-lambda”}
Completed 500 Internal Server Error in 101ms (ActiveRecord: 19.3ms)

NotImplementedError (NotImplementedError):
 app/models/service.rb:83:in `to_param’
 app/models/service.rb:79:in `to_param’
 app/models/project.rb:750:in `block in find_service’
 app/models/project.rb:750:in `find_service’
 app/models/project.rb:720:in `block in find_or_initialize_services’
 app/models/project.rb:719:in `map’
 app/models/project.rb:719:in `find_or_initialize_services’
 app/controllers/projects/settings/integrations_controller.rb:14:in `show’
 lib/gitlab/middleware/multipart.rb:93:in `call’
 lib/gitlab/request_profiler/middleware.rb:14:in `call’
 lib/gitlab/middleware/go.rb:16:in `call’
 lib/gitlab/etag_caching/middleware.rb:10:in `call’
 lib/gitlab/request_context.rb:18:in `call’

@tiagonbotelho Could you take another look?

Maybe we also need a test like we do on the admin services controller for the GET edit

I'm still getting a 500 error when clicking Integrations in 9.4.5, but the logged error is different:

ActiveRecord::SubclassNotFound (The single-table inheritance mechanism failed to locate the subclass: 'JenkinsDeprecatedService'. This error is raised because the column 'type' is reserved for storing the class in case of inheritance. Please rename this column if you didn't intend it to be used for storing the inheritance class or overwrite Service.inheritance_column to use another column for that information.):
  app/models/project.rb:842:in `find_service'
  app/models/project.rb:818:in `block in find_or_initialize_services'
  app/models/project.rb:811:in `map'
  app/models/project.rb:811:in `find_or_initialize_services'
  app/controllers/projects/settings/integrations_controller.rb:14:in `show'
  lib/gitlab/i18n.rb:45:in `with_locale'
  lib/gitlab/i18n.rb:51:in `with_user_locale'
  app/controllers/application_controller.rb:294:in `set_locale'
  lib/gitlab/performance_bar/peek_performance_bar_with_rack_body.rb:16:in `call'
  lib/gitlab/middleware/multipart.rb:93:in `call'
  lib/gitlab/request_profiler/middleware.rb:14:in `call'
  lib/gitlab/middleware/go.rb:16:in `call'
  lib/gitlab/etag_caching/middleware.rb:11:in `call'
  lib/gitlab/request_context.rb:18:in `call'
  lib/gitlab/metrics/requests_rack_middleware.rb:27:in `call'

This is still an issue for Gitlab CE and EE.

@fluidjeel Please can you raise a new issue and follow the bug report template?