Adding runners to gitlab.com/ci is broken

Because we have multiple workers for gitlab.com the register token differs between the workers.

We need to some how share the token between the workers.

Milestone changed to 8.1

The administrator registration token.

We should generate token and save it in settings and allow user to regenerate it.

The REGISTRATION_TOKEN is generated on Unicorn load (as shown here: https://gitlab.com/gitlab-org/gitlab-ce/blob/master/config/initializers/4_ci_app.rb#L5)

My proposal is to store this token in application_settings and allow to regenerate it from CI Admin Page.

/cc @dzaporozhets

@ayufan I am ok with that

Milestone changed to 8.2

mentioned in merge request !1724 (closed)

@ayufan I've decided to implement only the aplication_setting storage just because a token regeneration on a HA environment would be a hard implementation, it would require me to learn how all things are connected and design something like a redis pub/sub for token propagation. As this is also my first Ruby contribution, I would had to study Ruby's very basics.

If my MR changes are working, it should work for us, but this issue should only be closed if @dzaporozhets agrees that probably on-demand token regeneration isn't a good idea.

Added ~19173 label

This is already fixed in current version of GitLab, so I'm closing this issue.

Status changed to closed