gitlab-ci and empty commit string

Hi! i got 500 error while trying to view /ci/projects/1 Some of my programmers do not use commit messages :(

i am using gitlab 8.0.2

from logs

Started GET "/ci/projects/1" for xxxx at 2015-10-01 18:48:43 +0500
Processing by Ci::ProjectsController#show as HTML
  Parameters: {"id"=>"1"}
Started POST "/ci//api/v1/builds/register.json" for 212.33.226.47 at 2015-10-01 18:48:43 +0500
Completed 500 Internal Server Error in 89ms (ActiveRecord: 9.3ms)

ActionView::Template::Error (undefined method `chomp' for nil:NilClass):
    11:       %strong #{commit.short_sha}
    12:
    13:   %td.build-message
    14:     %span= truncate_first_line(commit.git_commit_message)
    15:
    16:   %td.build-branch
    17:     - unless @ref
  app/helpers/ci/commits_helper.rb:12:in `truncate_first_line'
  app/views/ci/commits/_commit.html.haml:14:in `_app_views_ci_commits__commit_html_haml__2327470826025812637_126097580'
  app/views/ci/projects/show.html.haml:53:in `_app_views_ci_projects_show_html_haml__3971616882816562695_125391280'


Started GET "/ci/projects/1" for xxxx at 2015-10-01 18:48:43 +0500
Processing by Ci::ProjectsController#show as HTML
  Parameters: {"id"=>"1"}
Completed 500 Internal Server Error in 77ms (ActiveRecord: 8.8ms)

Still got the same on 8.0.3

Seems to be an issue with line 12 in commits_helper.rb when message.each_line is nil

def truncate_first_line(message, length = 50)
  truncate(message.each_line.first.chomp, length: length) if message
end

Reassigned to @ayufan

Added ~19173 label

Reassigned to @grzesiek

Added ~16016 label

Status changed to closed

I think that this issue is already resolved in a new version of GitLab. I wasn't able to reproduce this problem:

Added a commit with empty message, browsed project and builds - it works for me. Thus, I'm closing this issue. Feel free to reopen if problem persist.

Additional findings: we have some obsolete CI related code in codebase. Already talked with @ayufan, and we will be able to safely remove it when CI->CE related refactorings are done.

mentioned in merge request !14785