Todo page count bug
With 55 todos in my account, my todos page count should be 3 since there are 20 todos on each page. However, when I am on my first page of todos it only looks like I have two pages. Going to my second page shows all three.
First page:
Second page:
The first page should show the third page.
Is this a known bug? cc @ClemMakesApps
Activity
I think @tauriedavis is seeing this due to responsive css with a smaller dimension.
On a larger dimension
Reduced dimension
I think
gl-paginationhas a css rule to hide content when the dimension is narrow. That should be the place to look and fix.Update:
Did some testing, turns out removing the
display:nonefrom thegl-paginationmedia queries will yield the following result
With the original
display:nonein place, we would get
Edited by username-removed-758669
What do you mean @ClemMakesApps? It looks like the issue list and branches are functioning the same. Todos is different and seems incorrect.
Thanks @tmlee for looking into the problem!
@tauriedavis @ClemMakesApps From my observation it seems that anywhere with pagination site-wide works with responsive and have got the same problem.
@tauriedavis do you know if you were viewing the todos page on a small screen?
As @tmlee mentioned, I think some pagination numbers disappear when the page screen is resized
Did it use to show ellipsis when the window is resized? @tauriedavis
Since pagination uses https://github.com/kaminari/kaminari
Kaminari renders the ellipsis when there are more pages that it needs to render
This issue will not appear when there are more than (probably) 5 pages in the pagination, since the ellipsis gets rendered by Kaminari. When responsive media queries kick in, the page button becomes hidden, and the ellipsis remains there which makes sense.
1 2 3 4 5 ... (Before resize) 1 2 ... (After resize)When there are less than say 5 pages however, Kaminari does not think it needs to truncate and will not render the ellipsis.
When the window is resized, the
gl-paginationmedia queries will kick in and hide some of those page numbers1 2 3 4 (Before resize, note no ellipsis) 1 2 (After resize, page 3 and 4 disappears)In my view, the things to consider would be
-
Do we want to hide those buttons if all of those buttons resized nicely from the responsiveness? That is users get to clearly see those page buttons and tap them.
-
Introduce a fix to insert the ellipsis, and make it hidden with a wide screen and appear on a narrow screen
Edited by username-removed-758669-
mentioned in issue #29658 (closed)
-
That makes sense! Thanks @tmlee!
I prefer #1 (closed) - to show all pages if they all still fit at all device sizes. There is no need to hide page 3-4 if there are only 4 pages and all buttons fit.
We only need the ellipses if there are 5+ pages, for example, and the number doesn't fit the responsiveness.
mentioned in issue #29950 (closed)
We introduced responsive pagination in this MR: https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/7157 as proposed in this issue: https://gitlab.com/gitlab-org/gitlab-ce/issues/23053 Not sure if this helps the discussion
moved to gitlab#8623
Hey!
GitLab is moving all development for both GitLab Community Edition and Enterprise Edition into a single codebase. The current
gitlab-cerepository will become a read-only mirror, without any proprietary code. All development is moved to the currentgitlab-eerepository, which we will rename to justgitlabin the coming weeks. As part of this migration, issues will be moved to the currentgitlab-eeproject.If you have any questions about all of this, please ask them in our dedicated FAQ issue.
https://gitlab.com/gitlab-org/gitlab-ee/issues/13855You can also find more information here:
https://gitlab.com/gitlab-org/gitlab-ee/issues/13304- https://about.gitlab.com/2019/08/23/a-single-codebase-for-gitlab-community-and-enterprise-edition/
Frequently Asked Questions
For an up to date list of questions and answers, please take a look at
https://gitlab.com/gitlab-org/gitlab-ee/issues/13855What will we do with the repository names?
https://gitlab.com/gitlab-org/gitlab-ee/ will become https://gitlab.com/gitlab-org/gitlab, and https://gitlab.com/gitlab-org/gitlab-ce will become https://gitlab.com/gitlab-org/gitlab-foss.
Why rename gitlab-ce to gitlab-foss?
Using "gitlab" and "gitlab-ce" would be confusing, so we decided to rename gitlab-ce to gitlab-foss to make the purpose of this FOSS repository more clear
I created a merge requests for CE, and this got closed. What do I need to do?
You will need to create a merge request at https://gitlab.com/gitlab-org/gitlab-ee/. This link will eventually redirect to https://gitlab.com/gitlab-org/gitlab.
How does the licensing work in this new setup?
Everything in the
ee/directory is proprietary. Everything else is free and open source software. If your merge request does not change anything in theee/directory, the process of contributing changes is the same as when using the gitlab-ce repository.Will you accept merge requests on the gitlab-ce/gitlab-foss project after it has been renamed?
No. Merge requests submitted to this project will be closed automatically.
Will I still be able to view old issues and merge requests in gitlab-ce/gitlab-foss?
Yes.
How will this affect users of GitLab CE using Omnibus?
No changes will be necessary, as the packages built remain the same.
How will this affect users of GitLab CE that build from source?
Once the project has been renamed, you will need to change your Git remotes to use this new URL. GitLab will take care of redirecting Git operations so there is no hard deadline, but we recommend doing this as soon as the projects have been renamed.
Where can I see a timeline of the remaining steps?
https://gitlab.com/gitlab-org/gitlab-ee/issues/13304Will community contributions submitted to the new "gitlab" repository be available in the new gitlab-foss repository?
Yes, these changes will be synced to gitlab-foss automatically, several times per day.
