GitLab 7.14/8.0: code discussion contents not shown in commit page after upgrade form 7.13.5 to 8.0.3
I recently upgraded from GitLab 7.13.5 to 8.0.3, in two stages -- first form 7.13.5 to 7.14.3, and then from 7.14.3 to 8.0.3.
After this upgrade was complete, as part of normal testing, I noticed that commit file comments (for changed lines) do not seem to be displayed. They do seem to be persisted. However, I do not see any errors in the logfiles.
Steps to repro:
- push a commit modifying a file -- date > hello.txt
- in GitLab UI (as any user -- admin or not), navigate to commit
- click to the left of one of the changed lines to comment on it, click add comment
- enter a comment. the UI shows the comment.
- now refresh the page. the UI no longer shows the comment. click the toggle comment button, but still the comment does not show
- click on the project view, click comments. Here you can see the comments.
Comments at the commit level itself (not on a specific file line) are visible. It appears to only be an issue for file line comments.
Any ideas what might be causing this? We frequently use this feature for code reviews, so being unable to see the comments is a concern for us.
Activity
mentioned in issue #2572 (closed)
Hmm, possibly related to the file or file size. It does not seem to occur for all files.
In this particular case it was a file with a single line, which the commit modified. I tried another file in the same repo with multiple lines, and do not see this issue. I also tried another file in a different repo with multiple lines, and do not see this issue.
Yep, seems to depend on file size. For a 1 or 2-line file I see the issue.
For a 3 or more line file I do not see the issue.
So this is appears to be an uncommon/unlikely issue. Updated repro steps above to create single line file.
Edited by username-removed-41483Not an uncommon issue. I could see this on a multi line file also. I am on Gitlab 8.9.2 and after comment/page refresh, only thing visible is "@user commented about X hours ago". If I need to see the comment, I need to click the edit icon( but other user don't have edit option on my comment and so they cannot see ). Toggle comments for this file option, just hides or display the above message and not the comment itself.
At top of commit page, I can see a disabled button which shows a comment icon with number of comments on page.
On project Activity tab, under comments section, I cannot see any comment :(
Hi @sroth80021,
First of all, thank you for raising an issue to help improve the GitLab product. We're sorry about this, but this particular issue has gone unnoticed for quite some time. To establish order in the GitLab-CE Issue Tracker, we must ensure that every issue is correctly labelled and triaged, to get the proper attention.
This issue will be closed, as it meets the following criteria:
- No activity in the past 4 months
- Unlabelled
- Unassigned
- It's not associated with a particular milestone
We'd like to ask you to help us out and determine whether this issue should be reopened.
If this issue is reporting a bug, please can you attempt to reproduce on the latest version of GitLab or GitLab.com, to help us to understand whether the bug still needs our attention.
If this issue is proposing a new feature, please can you verify whether the feature proposal is still relevant.
Thanks for your help
