Add project ID to CI_ENVIRONMENT_URL in templates and auto deploy

Description

https://gitlab.com/gitlab-org/gitlab-ce/issues/27193 made auto deploy templates support multiple apps in the same cluster, but only if there's only one project of the same name per KUBE_DOMAIN. If someone is using forks, but within the same company, or otherwise has multiple projects with the same name trying to share the same KUBE_DOMAIN base domain, this is likely to break. Perhaps we should include the CI_PROJECT_ID in the CI_ENVIRONMENT_URL as well, so it's unique across the entire base domain (assuming you've only got once instance of GitLab per KUBE_DOMAIN).

Proposal

Links / references

• https://gitlab.com/gitlab-org/gitlab-ce/issues/27193

/cc @ayufan @zj

If someone is using forks, but within the same team, this is likely to break.

Do you mean with nested teams?

Then it will also not work, as fork may need separate secrets or integrations and will also have the separate set of "environments". Missing this: https://gitlab.com/gitlab-org/gitlab-ce/issues/23902

mentioned in issue #32638 (moved)

@zj I meant the people work in the same company. The fork may exist in their personal namespace.

@ayufan This has nothing to do with running pipelines for merge requests. I'm thinking about the I2P flow, where you set up K8s service integration at the instance level, so all secrets are shared. And I only have one domain name purchased for the entire company. So projects of the same name need to have unique URLs.

added idea-to-production label

changed the description

Hmm, right, but we do allow you to specify any domain. Are you proposing to make KUBE_DOMAIN be a part of Kubernetes Service?

@ayufan No, not necessarily. It's just that in practice, it's likely for people to reuse KUBE_DOMAIN across groups. Specifically, it happens in the current I2P demo, and people need to add their initials to project names to avoid collisions.

changed milestone to %9.4

mentioned in issue #32829 (closed)

moved to gitlab-ci-yml#26 (closed)

added Deliverable ~901060 labels

marked this issue as related to #32829 (closed)