Task list overwrites changes
Summary
When checking a task item (from Task List) it will update the issue with the content in your browser and potentially overwrite all changes made by other users since last time you refreshed your browser.
Steps to reproduce
- In browser A create an issue with a Task list
- Load the issue in browser B
- Make some changes in browser A (and save)
- Check a task in the task list from browser B (without reloading the page first)
- Changes made in browser A is gone as B had overwritten it (reload A to se your changes are gone),
What is the current bug behavior?
When (un) checking a task in a tasklist issue content in the browser overwrites version at the server, even when the content, is changed by other users since last html reload
What is the expected correct behavior?
Check if the issue has been updated since the page has been loaded and warn user that the issue needs to be reloaded as other users has changed it,
Relevant logs and/or screenshots
Output of checks
(If you are reporting a bug on GitLab.com, write: This bug happens on GitLab.com)
Results of GitLab environment info
System information
System: Ubuntu 14.04
Current User: git
Using RVM: no
Ruby Version: 2.3.3p222
Gem Version: 2.6.6
Bundler Version:1.13.7
Rake Version: 10.5.0
Redis Version: 3.2.5
Sidekiq Version:4.2.7
GitLab information
Version: 8.17.3
Revision: f0c970e
Directory: /opt/gitlab/embedded/service/gitlab-rails
DB Adapter: postgresql
URL: -(removed)
HTTP Clone URL: -(removed)
SSH Clone URL: -(removed)
Using LDAP: no
Using Omniauth: no
GitLab Shell
Version: 4.1.1
Repository storage paths:
- default: /var/opt/gitlab/git-data/repositories
Hooks: /opt/gitlab/embedded/service/gitlab-shell/hooks/
Git: /opt/gitlab/embedded/bin/git Results of GitLab application Check
Checking GitLab Shell ...
GitLab Shell version >= 4.1.1 ? ... OK (4.1.1)
Repo base directory exists?
default... yes
Repo storage directories are symlinks?
default... no
Repo paths owned by git:git?
default... yes
Repo paths access is drwxrws---?
default... yes
hooks directories in repos are links: ...
4/2 ... ok
4/3 ... ok
4/4 ... ok
4/5 ... ok
4/7 ... ok
4/8 ... ok
4/9 ... ok
4/10 ... ok
4/11 ... ok
4/12 ... ok
4/14 ... ok
4/15 ... ok
4/16 ... ok
4/17 ... ok
4/18 ... ok
4/19 ... ok
4/22 ... ok
4/23 ... ok
2/24 ... ok
4/25 ... ok
4/26 ... ok
4/28 ... ok
4/30 ... ok
4/31 ... ok
4/32 ... repository is empty
16/33 ... ok
16/34 ... ok
2/35 ... ok
16/36 ... ok
16/37 ... ok
16/38 ... ok
16/39 ... ok
16/40 ... ok
16/41 ... ok
16/42 ... ok
16/44 ... ok
4/45 ... ok
16/46 ... ok
16/47 ... ok
16/48 ... ok
16/49 ... ok
16/50 ... ok
4/51 ... ok
16/52 ... ok
16/53 ... ok
16/54 ... ok
16/55 ... ok
16/56 ... ok
16/58 ... ok
4/59 ... ok
4/60 ... ok
3/63 ... ok
16/65 ... ok
16/66 ... ok
16/67 ... ok
16/68 ... ok
16/70 ... ok
16/71 ... ok
4/72 ... ok
4/73 ... ok
4/74 ... ok
4/75 ... ok
16/76 ... ok
16/77 ... ok
4/78 ... ok
16/80 ... ok
20/81 ... ok
20/82 ... ok
19/85 ... ok
16/86 ... ok
16/87 ... ok
Running /opt/gitlab/embedded/service/gitlab-shell/bin/check
Check GitLab API access: OK
Access to /var/opt/gitlab/.ssh/authorized_keys: OK
Send ping to redis server: OK
gitlab-shell self-check successful
Checking GitLab Shell ... Finished
Checking Sidekiq ...
Running? ... yes
Number of Sidekiq processes ... 1
Checking Sidekiq ... Finished
Checking Reply by email ...
Reply by email is disabled in config/gitlab.yml
Checking Reply by email ... Finished
Checking LDAP ...
LDAP is disabled in config/gitlab.yml
Checking LDAP ... Finished
Checking GitLab ...
Git configured with autocrlf=input? ... yes
Database config exists? ... yes
All migrations up? ... yes
Database contains orphaned GroupMembers? ... no
GitLab config exists? ... yes
GitLab config outdated? ... no
Log directory writable? ... yes
Tmp directory writable? ... yes
Uploads directory setup correctly? ... yes
Init script exists? ... skipped (omnibus-gitlab has no init script)
Init script up-to-date? ... skipped (omnibus-gitlab has no init script)
projects have namespace: ...
4/2 ... yes
4/3 ... yes
4/4 ... yes
4/5 ... yes
4/7 ... yes
4/8 ... yes
4/9 ... yes
4/10 ... yes
4/11 ... yes
4/12 ... yes
4/14 ... yes
4/15 ... yes
4/16 ... yes
4/17 ... yes
4/18 ... yes
4/19 ... yes
4/22 ... yes
4/23 ... yes
2/24 ... yes
4/25 ... yes
4/26 ... yes
4/28 ... yes
4/30 ... yes
4/31 ... yes
4/32 ... yes
16/33 ... yes
16/34 ... yes
2/35 ... yes
16/36 ... yes
16/37 ... yes
16/38 ... yes
16/39 ... yes
16/40 ... yes
16/41 ... yes
16/42 ... yes
16/44 ... yes
4/45 ... yes
16/46 ... yes
16/47 ... yes
16/48 ... yes
16/49 ... yes
16/50 ... yes
4/51 ... yes
16/52 ... yes
16/53 ... yes
16/54 ... yes
16/55 ... yes
16/56 ... yes
16/58 ... yes
4/59 ... yes
4/60 ... yes
3/63 ... yes
16/65 ... yes
16/66 ... yes
16/67 ... yes
16/68 ... yes
16/70 ... yes
16/71 ... yes
4/72 ... yes
4/73 ... yes
4/74 ... yes
4/75 ... yes
16/76 ... yes
16/77 ... yes
4/78 ... yes
16/80 ... yes
20/81 ... yes
20/82 ... yes
19/85 ... yes
16/86 ... yes
16/87 ... yes
Redis version >= 2.8.0? ... yes
Ruby version >= 2.1.0 ? ... yes (2.3.3)
Your git bin path is "/opt/gitlab/embedded/bin/git"
Git version >= 2.7.3 ? ... yes (2.10.2)
Active users: 9
Checking GitLab ... FinishedPossible fixes
?