Issue with ordering in upgrade instructions for 9.0
Summary
If you follow upgrade instructions here: https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/update/8.17-to-9.0.md
it calls for running db migrate after bundle clean AND prior to updating config files. Problem is that the db migrate is now requiring the new gitlab shell version AND is expecting the repo paths to be changed in the config. This needs moved down to after step 9.
Steps to reproduce
Follow upgrade instructions as written.
What is the current bug behavior?
Instructions don't work.
What is the expected correct behavior?
Instructions should be in order that will actually work.
Relevant logs and/or screenshots
git@git-d1:~/gitlab$ bundle exec rake db:migrate RAILS_ENV=production
WARNING: This version of GitLab depends on gitlab-shell 5.0.0, but you're running 4.1.1. Please update gitlab-shell.
D, [2017-03-20T08:02:28.946602 #37220] DEBUG -- sentry: ** [Raven] default is not a valid storage, because it has no `path` key. It may be configured as:
default:
path: /local/git/repos/
For source installations, update your config/gitlab.yml Refer to gitlab.yml.example for an updated example.
If you're using the Gitlab Development Kit, you can update your configuration running `gdk reconfigure`.
excluded from capture due to environment or should_capture callback
rake aborted!
default is not a valid storage, because it has no `path` key. It may be configured as:
default:
path: /local/git/repos/
For source installations, update your config/gitlab.yml Refer to gitlab.yml.example for an updated example.
If you're using the Gitlab Development Kit, you can update your configuration running `gdk reconfigure`.
/local/git/gitlab/config/initializers/6_validations.rb:23:in `block in validate_storages_config'
Possible fixes
Just move the mirgate/clean/precompile steps to after the update of config files and gitlab-shell in the install docs.