Remove scroll into view when clicking MR "Changes" tab

We should remove the forced scrollTo when switching to the "Changes"/diff tab on a MR.

Aside from it being a slightly annoying personally, we don't force the scroll for any of the other tabs even though "Pipelines" and "Commits" also have loading indicators.

See original issue that introduced the change https://gitlab.com/gitlab-org/gitlab-ce/issues/15133

---

cc @jschatz1 @dimitrieh

@MadLittleMods could you provide me some visuals in the form of a gif? you can make one easily with for example https://getkap.co/ or see for more info https://about.gitlab.com/handbook/product/making-gifs/

@dimitrieh Added to OP

added ~13921 label

@MadLittleMods this is weird indeed and should be have like the rest

@smcgivern can this be considered a regression ?

added frontend ~12980 and removed ~19492 ~65372 labels

@dimitrieh no, it's been around since 8.8

https://gitlab.com/gitlab-org/gitlab-ce/blob/master/PROCESS.md#feature-freeze

only fixes for regressions (bugs introduced in that same release) and security issues will be cherry-picked into the stable branch

mmh, then we should just fix @MadLittleMods you want to take this up?

@markglenfletcher @smcgivern are there duplicate issues?

It's not a regression but it is annoying. Let's fix it! @MadLittleMods Feel free or we can add Accepting Merge Requests

@dimitrieh I don't recall seeing any

assigned to @MadLittleMods

mentioned in commit 578b9011

mentioned in merge request !10194 (merged)

closed via merge request !10194 (merged)

mentioned in merge request !14785