View real-time updates of issue / merge request sidebar

Resources

FE @psimyn

Description

• Within an issue or merge request, view labels update in a real-time.
• View assignees in real-time.
• View tracking information in real-time.
• View milestone in real-time.
• View due date in real-time.
• Also account for when sidebar is open vs collapsed
• Any special transitions? This is the standard for text transitions:https://docs.gitlab.com/ee/development/ux_guide/animation.html#quick-update

changed milestone to %Backlog

added ~874211 frontend ~19492 ~897282 to schedule labels

changed title from View real-time updates of issue / merge request labels to View real-time updates of issue / merge request sidebar

changed milestone to %9.2

removed ~897282 to schedule labels

@tauriedavis @smcgivern @jschatz1 : Take a look. I made this 9.2

mentioned in issue #29980 (closed)

We're going to do this by using the existing notes polling, with the new note types @jarka has added, and use those to trigger a fetch of the JSON representation of the issue / MR.

added Deliverable label

As discussed in Slack, another possibility is to add a single endpoint that returns everything that we want to update in real-time (title, labels, milestone, assignee, ...), uses ETag caching and is invalidated when issuable changes.

Please note if we decide to use notes polling for it, we will only be able to do it for issue, because https://gitlab.com/gitlab-org/gitlab-ce/issues/29939 is not easy.

assigned to @psimyn

@psimyn just a heads up, we are also going to get https://gitlab.com/gitlab-org/gitlab-ee/issues/1904 in this release so it might get a little crazy. It maybe a good idea to branch off of our review branch but there will be a lot of conflicts along the way.

I am refactoring the assignees part of the sidebar into a vue component, so just wanted to give you a heads up.

I also noticed that the time tracking part of the sidebar is also already a vue component. That component actually calls the JSON endpoint to get it's initial values, we will probably want to refactor that out so that we can do one JSON request and use that data to populate all the other initial values (assignee, milestone..etc) instead of passing it using inline javascript/data attributes. Depending on time, I might be passing initial values for assignees using inline javascript and that can be refactored on your MR as I assume you will be transforming the entire sidebar into a vue component

@ClemMakesApps @psimyn : I don't think this is mission critical to get out for 9.2. Given what @ClemMakesApps says (https://gitlab.com/gitlab-org/gitlab-ce/issues/29982#note_27365698), does it make sense to at least de-scope the assignees portion of this issue, or just flat-out defer it to another release? There's no shortage of work and we can score other real-time areas too instead.

cc @jschatz1

If it's not as high priority as other issues, I think it might be easier to push this back a release but I'll defer to @jschatz1

removed milestone

added ~897282 to schedule labels

@jschatz1 : I removed the milestone per above.

removed assignee

Per discussion with @jschatz1 : making this stretch for 9.1

Do you mean 9.2?

added Stretch and removed ~874211 frontend ~19492 ~897282 to schedule labels

changed milestone to %9.1

added ~874211 frontend ~19492 labels

removed Deliverable ~874211 frontend ~19492 labels

added Deliverable label

removed Stretch label

added ~874211 frontend ~19492 labels

changed milestone to %9.2

added Stretch label

removed Deliverable label

Thanks @ClemMakesApps . My mistake. Updated to 9.2 stretch as discussed.

mentioned in issue #31227 (moved)

mentioned in issue #26308 (closed)

added real-time label

changed milestone to %Backlog

added to schedule label

mentioned in issue #25453 (moved)

changed milestone to %Next 2-3 months

removed to schedule label

marked this issue as related to #30733 (moved)

moved to gitlab#8943

Hey!

GitLab is moving all development for both GitLab Community Edition and Enterprise Edition into a single codebase. The current gitlab-ce repository will become a read-only mirror, without any proprietary code. All development is moved to the current gitlab-ee repository, which we will rename to just gitlab in the coming weeks. As part of this migration, issues will be moved to the current gitlab-ee project.

If you have any questions about all of this, please ask them in our dedicated FAQ issue.

https://gitlab.com/gitlab-org/gitlab-ee/issues/13855

You can also find more information here:

• https://gitlab.com/gitlab-org/gitlab-ee/issues/13304
• https://about.gitlab.com/2019/08/23/a-single-codebase-for-gitlab-community-and-enterprise-edition/

Frequently Asked Questions

For an up to date list of questions and answers, please take a look at https://gitlab.com/gitlab-org/gitlab-ee/issues/13855

What will we do with the repository names?

https://gitlab.com/gitlab-org/gitlab-ee/ will become https://gitlab.com/gitlab-org/gitlab, and https://gitlab.com/gitlab-org/gitlab-ce will become https://gitlab.com/gitlab-org/gitlab-foss.

Why rename gitlab-ce to gitlab-foss?

Using "gitlab" and "gitlab-ce" would be confusing, so we decided to rename gitlab-ce to gitlab-foss to make the purpose of this FOSS repository more clear

I created a merge requests for CE, and this got closed. What do I need to do?

You will need to create a merge request at https://gitlab.com/gitlab-org/gitlab-ee/. This link will eventually redirect to https://gitlab.com/gitlab-org/gitlab.

How does the licensing work in this new setup?

Everything in the ee/ directory is proprietary. Everything else is free and open source software. If your merge request does not change anything in the ee/ directory, the process of contributing changes is the same as when using the gitlab-ce repository.

Will you accept merge requests on the gitlab-ce/gitlab-foss project after it has been renamed?

No. Merge requests submitted to this project will be closed automatically.

Will I still be able to view old issues and merge requests in gitlab-ce/gitlab-foss?

Yes.

How will this affect users of GitLab CE using Omnibus?

No changes will be necessary, as the packages built remain the same.

How will this affect users of GitLab CE that build from source?

Once the project has been renamed, you will need to change your Git remotes to use this new URL. GitLab will take care of redirecting Git operations so there is no hard deadline, but we recommend doing this as soon as the projects have been renamed.

Where can I see a timeline of the remaining steps?

https://gitlab.com/gitlab-org/gitlab-ee/issues/13304

Will community contributions submitted to the new "gitlab" repository be available in the new gitlab-foss repository?

Yes, these changes will be synced to gitlab-foss automatically, several times per day.

locked this issue