500 Error at integrations page of project after upgrading to 9.0.0

Summary

Error 500 when calling this URL https://url.de/group/project/settings/integrations

Steps to reproduce

Refreshing the page? :) Doesn't happen for other projects, though

Relevant logs and/or screenshots

Shared Sentry log: https://sentry.io/share/issue/38303239312e323432303339363433/

Gitlab:check https://hastebin.com/cuqegivuda.txt Gitlab:env https://hastebin.com/xikinapuni.txt

Thank you! I hope the information I provided is sufficient.

---

https://gitlab.zendesk.com/agent/tickets/74519

It's possible that this project has a service in the database that is not defined. Get the project ID, and in your database (e.g. run sudo gitlab-rails dbconsole) try:

SELECT type, title FROM services where project_id = X

where X is the project ID (seen in the settings)

Response is (also included active in the result):

id | type | title | active ------+---------------------------+---------------+-------- 2132 | | Builds emails | f 3191 | GitlabIssueTrackerService | | f 2140 | | Slack | t 2149 | | | f 2190 | SlackService | | t

Should I delete the entries without type?

Probably. Did you happen to use the project importer at some point?

This fixed it, thanks. And yes we did, about a year erlier we had a similiar problem, and reimporting a project would fix it.

Thanks

closed

@stanhu in the above resultant table which records do we need to remove for fixing this issue?

Ones without the type is fine or we also have to remove the nil type? Got this query from one of the customer.

There are 71 other rows with "(type IS NULL OR type = '')" (on 41 projects). Is it safe to delete those?

@arihantar Probably, but it's probably a good idea to back the database up. I'd be curious to know how this happened in the first place.

@stanhu from what I see there is no validation to keep Services from having type as null. We should probably have that fixed! \cc @DouweM can you confirm that there should not exist any Services with nil type?

@tiagonbotelho Yes. FYI, on GitLab.com, we have 57 of these:

irb(main):067:0> Service.where(type: nil).count                                                                                                                                                                   
=> 57
```

@tiagonbotelho Correct, shouldn't exist, since Service is supposed to be an abstract class.

I'll create a MR for this tomorrow. @stanhu do we need a migration for this or can we do it in the production DB directly?

Migration.

mentioned in merge request !10847 (merged)

@stanhu: It looks like all projects who have a service with (type IS NULL OR type = '') are imported from an old GitLab CE instance. Projects which are created on the running GitLab EE instance are not affected. Service titles are Builds emails and JIRA EDIT: Deleting the other 41 affected services has resolved many 500 errors and no problems occurred.

reopened

I am reopening the issue since https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/10847/diffs is made to fix this.

There was an MR to do with type being nil that was resolved late September, 2016. That probably fixed the cause and it's also consistent with what we have in prod/staging:

> Service.where(type: nil).count
=> 49
> Service.where(type: nil).order(:created_at).pluck(:created_at).first
=> Sat, 24 Sep 2016 20:10:35 UTC +00:00

That was the last time we created a service with type = nil, so it should be safe to run this migration now.

mentioned in issue #31481 (closed)

added customer+ services labels

closed

mentioned in issue #31502 (closed)