bundle exec rake gitlab:check fails to properly detect running sidekiq
Summary
running bundle exec rake gitlab:check RAILS_ENV=production fails to properly detect running sidekiq process.
Steps to reproduce
Install GitLab on OpenBSD 6.1-beta and run mentioned rake command as the gitlab user. See it failing.
What is the current bug behavior?
gitlab:check rake test, important for problem reports here and general administration, fails to properly detect running sidekiq process(es)
What is the expected correct behavior?
it should just work
Relevant logs and/or screenshots
none
Output of checks
Results of GitLab environment info
PATH=/var/www/gitlab/bin:$PATH bundle exec rake gitlab:env:info RAILS_ENV=production
System information
System:
Current User: _gitlab
Using RVM: no
Ruby Version: 2.3.3p222
Gem Version:
Bundler Version:1.13.6
Rake Version: 10.5.0
Redis Version: 3.2.6
Sidekiq Version:4.2.7
GitLab information
Version: 8.17.4
Revision: 3d2890c86a
Directory: /var/www/gitlab/gitlab
DB Adapter: postgresql
URL: https://galen.l00-bugdead-prods.de/gitlab
HTTP Clone URL: https://galen.l00-bugdead-prods.de/gitlab/some-group/some-project.git
SSH Clone URL: _gitlab@galen.l00-bugdead-prods.de:some-group/some-project.git
Using LDAP: yes
Using Omniauth: no
GitLab Shell
Version: 4.1.1
Repository storage paths:
- default: /var/www/gitlab/repositories
Hooks: /var/www/gitlab/gitlab-shell/hooks/
Git: /usr/local/bin/git
Results of GitLab application Check
This is the output of the 'fixed' version I have in a MR I just prepare.
PATH=/var/www/gitlab/bin:$PATH bundle exec rake gitlab:check RAILS_ENV=production SANITIZE=true
Checking GitLab Shell ...
GitLab Shell version >= 4.1.1 ? ... OK (4.1.1)
Repo base directory exists?
default... yes
Repo storage directories are symlinks?
default... no
Repo paths owned by _gitlab:_gitlab?
default... yes
Repo paths access is drwxrws---?
default... no
Try fixing it:
sudo chmod -R ug+rwX,o-rwx /var/www/gitlab/repositories
sudo chmod -R ug-s /var/www/gitlab/repositories
sudo find /var/www/gitlab/repositories -type d -print0 | sudo xargs -0 chmod g+s
For more information see:
doc/install/installation.md in section "GitLab Shell"
Please fix the error above and rerun the checks.
hooks directories in repos are links: ...
2/2 ... repository is empty
2/3 ... repository is empty
2/4 ... repository is empty
Running /var/www/gitlab/gitlab-shell/bin/check
Check GitLab API access: FAILED: Failed to connect to internal API
gitlab-shell self-check failed
Try fixing it:
Make sure GitLab is running;
Check the gitlab-shell configuration file:
sudo -u _gitlab -H editor /var/www/gitlab/gitlab-shell/config.yml
Please fix the error above and rerun the checks.
Checking GitLab Shell ... Finished
Checking Sidekiq ... yes
Number of Sidekiq processes ... 1
Checking Sidekiq ... Finished
Checking Reply by email ...
Reply by email is disabled in config/gitlab.yml
Checking Reply by email ... Finished
Checking LDAP ...
Server: ldapmain
LDAP authentication... Success
LDAP users with access to your GitLab server (only showing the first 100 results)
... a couple of LDAP users ...
Checking LDAP ... Finished
Checking GitLab ...
Git configured with autocrlf=input? ... yes
Database config exists? ... yes
All migrations up? ... yes
Database contains orphaned GroupMembers? ... no
GitLab config exists? ... yes
GitLab config outdated? ... no
Log directory writable? ... yes
Tmp directory writable? ... yes
Uploads directory setup correctly? ... skipped (no tmp uploads folder yet)
Init script exists? ... no
Try fixing it:
Install the init script
For more information see:
doc/install/installation.md in section "Install Init Script"
Please fix the error above and rerun the checks.
Init script up-to-date? ... can't check because of previous errors
projects have namespace: ...
2/2 ... yes
2/3 ... yes
2/4 ... yes
Redis version >= 2.8.0? ... yes
Ruby version >= 2.1.0 ? ... yes (2.3.3)
Your git bin path is "/usr/local/bin/git"
Git version >= 2.7.3 ? ... yes (2.11.0)
Active users: 2
Checking GitLab ... Finished
Possible fixes
https://gitlab.com/gitlab-org/gitlab-ce/blob/master/lib/tasks/gitlab/check.rake#L620
The problem seems to be in 'lib/tasks/gitlab/check.rake' how ruby is calling the 'ps ux'. Don't know exactly if this is a general problem with ruby, or from the OpenBSD ps utility. However, I added output and it seems, the ps output is trucated at 80 chars, so that the pattern matching afterward doesn't work properly. Not sure if ruby tells ps the terminal widht is 80 chars, or if ruby doesn't tell anything at all, and then the fallback of the OpenBSD ps binary is to assume 80 chars. However, the fix then was easy, just add 'ww' parameters to the call to ps.