Creating custom/pattern protected branch jumping scroll to top

Summary

Creating custom/pattern protected branch jumps your scroll position to the top of the page

Steps to reproduce

1. Visit group/some-project/settings/repository
2. Scroll to the "Protected Branches" section
3. Click the "Branch" select box and enter your own pattern like protected-*
4. Click the "Create wilcard protected-*" button
5. Notice how you are scrolled to top and have a empty hash fragment # in the URL

What is the current bug behavior?

When creating a protected branch pattern, you are scrolled to top and have a empty hash fragment # in the URL

What is the expected correct behavior?

Clicking "Create wildcard ..." won't move the scroll position

Output of checks

This bug happens on GitLab.com

Possible fixes

• e.preventDefault();
• Use button element over a <a href="#">

mentioned in commit 550adacb

mentioned in merge request !10275 (merged)

closed via merge request gitlab-ee!1523

mentioned in commit 79275ca0

mentioned in merge request !14785