Pipelines: When we retry a pipeline 2 requests are made to the pipelines endpoint

After we removed UJS actions from pipelines table we now have 2 requests being made every time we click an action:

1. Made by the action itself:
2. Made by Vue.js - which is expected. We tell it to fetch again when we received the response

The first one fires immediately after the action is clicked and it shouldn't.

@grzesiek @ayufan how can we remove this?

@filipa So it appears that we want buttons that do nothing, is that correct? Should make it possible to define an attribute on the link_to, button_to that would result in preventDefault? If I don't understand the problem here, please explain it to me Shouldn't that be already handled by Vue?

@filipa the first request is due to the 302 from cancel POST request (initiator column in devtools).

There is redirect_back_or_default in pipelines_controller, I think giving a json response instead would prevent this.

since the request is for a single pipeline, could you send just that pipeline in the POST response? Then you don't need full reload of pipelines

@grzesiek yes! Buttons that do nothing. But I think we need to do what @psimyn is suggesting.

This is all in Vue now, so we don't use haml links or UJS actions. Is it possible if this endpoint could return 200ok an do not redirect?

@psimyn regarding your suggestion of sending just the pipeline in the response, yes we could do that.

What do you think @grzesiek

mentioned in merge request !10219 (merged)

It is possible to respond with 200 and send some JSON response if format is json in the request.

Is backend ready for that? If I remember correctly, I tried that in some endpoints and received 500

@filipa Usually it is a matter of adding yet another format.json do; end block, shouldn't be too hard. Not sure if this is a case here.

assigned to @filipa

mentioned in merge request !10584 (merged)

changed milestone to %9.2

@brycepj this is the MR where i am trying to change the response of the retry/cancel request :)

added Deliverable label

closed via merge request !10584 (merged)

mentioned in commit a5347fe5