Changing group name with subgroups causes repository disappearance

Summary

In version 9.0.1 renaming a group that has subgroups and projects within those subgroups causes repository disappearance (No repository)

Steps to reproduce

1. Base structure:
   Group1/Project1
   Group1/Project2

2. Subgroups creation:
   Group1/Project1
   Group1/Project2
   Group1/SupGroup1
   Group1/SupGroup2

3. Moving projects
   Group1/SupGroup1/Project1
   Group1/SupGroup2/Project2

4. Renaming main group to Group1R:
   Group1R/SupGroup1/Project1
   Group1R/SupGroup2/Project2

5. Entering Project1 shows 'No repository' info

What is the current bug behavior?

The projects are not correctly moved (repositories on disk are still in old paths)

Relevant logs and/or screenshots

Unfortunately we don't have any logs because we had to quick restore backup of previous version of gitlab

closed

reopened

Exact same situation here.

/cc: @reprazent

@rafal.brozek @alcateltouch11 Sorry you were affected by this. And thank you for the excellent description!

This case was not handled by the 9.0.2, in which we only handle the bug where renaming a subgroup (Subgroup1 & Subgroup2 in this example) would move it to the root directory.

I was able to reproduce this in GitLab.com, thank you for bringing it to our attention.

added settings subgroups labels

/cc @dzaporozhets

added Next Patch Release label

changed milestone to %9.1

assigned to @dzaporozhets

I will take a look

Reproduced on GitLab.com (EE 9.0.2) but cant reproduce on latest CE master. Either ee-only or fixed in master

ok reproduced on ce master too

mentioned in merge request !10414 (merged)

closed via merge request !10414 (merged)

mentioned in commit 271ab515

mentioned in commit 65b04fdb

We upgraded version to 9.1.2 and unfortunately problem still exists, however bug behavior is slightly different.

After renaming main group the project page shows error 404.

In browser url i can see that project address has old name of the main group: server/TestGroup/TestSubgroup/TestProj it should be: server/TestGroupRenamed/TestSubgroup/TestProj

Addidtional info: when I use "Search" box for finding TestProj it shows correct page with valid link.

So there is still problem with subgroups metadata when renaming main group..

reopened

@rafal.brozek Can you reproduce in on GitLab.com? I just tried and it works well for me. Maybe there is something I missed.

Yes.
I have tried a few times on GitLab, and it's not always happen, but it does happen.
Sometimes with first rename of the main group and sometimes when i do it second time like with this project in sub group:
https://gitlab.com/Test1_GroupRen/Test1_SubGroup (404 after click on project)
but project exists:
https://gitlab.com/Test1_GroupRen/Test1_SubGroup/Test1_Project

I don't know is it important but my project is not empty, it has at least one commit.

I have created a structure:
Test1_Group / Test1_SubGroup / Test1_Project
Then renamed to the main group:
Test1_GroupRenamed / Test1_SubGroup / Test1_Project (project still working)
And renamed again:
Test1_GroupRen / Test1_SubGroup / Test1_Project (404)

but my GitLab at work I had 404 in first test right after first rename.

@rafal.brozek Thanks for the detailed description!

Your project did get moved correctly, it's available here: https://gitlab.com/Test1_GroupRen/Test1_SubGroup/Test1_Project. So it looks like a different problem then the original one, which caused GitLab to show No Repository instead of a 404.

I believe the problem is that the fragment cache for the project in the list (views/shared/projects/_project.html.haml) isn't expired as it should. But it is very strange it only happens the second rename.

mentioned in issue #31863 (closed)

I created https://gitlab.com/gitlab-org/gitlab-ce/issues/31863 to track this new issue. So I'll close this

closed

@reprazent thanks, indeed looks like cache issue