PlantUML integration stopped working with 9.0.4 and 8.17.5

Summary

When using PlantUML integration, the upgrade to either 8.17.5 (from 8.17.4) or 9.0.4 (from 9.0.3) breaks the display of the diagram. It displays the code.

Steps to reproduce

Install GitLab 8.17.4 or 9.0.3, install PlantUML server. Configure in GitLab settings the integration, past the following in a wiki (remove the spaces between each '`'):

` ` `plantuml
@startuml
Bob -> Alice : hello
@enduml
` ` `

It works. Now upgrade to 8.17.5 or 9.0.4, try again and it does not work.

What is the current bug behavior?

It display the code rather than the graphic.

What is the expected correct behavior?

Display the graphic (as it was doing in previous releases.

Relevant logs and/or screenshots

The log message do not show any relevant messages sadly.

Output of checks

Done on a test instance running 9.0.4. But same output on production (just with much more repositories)

# docker exec -it spcbo_gitlab_ext gitlab-rake gitlab:check SANITIZE=true
Checking GitLab Shell ...

GitLab Shell version >= 5.0.0 ? ... OK (5.0.0)
Repo base directory exists?
default... yes
Repo storage directories are symlinks?
default... no
Repo paths owned by git:git?
default... yes
Repo paths access is drwxrws---?
default... yes
hooks directories in repos are links: ...
1/1 ... repository is empty
Running /opt/gitlab/embedded/service/gitlab-shell/bin/check
Check GitLab API access: OK
Access to /var/opt/gitlab/.ssh/authorized_keys: OK
Send ping to redis server: OK
gitlab-shell self-check successful

Checking GitLab Shell ... Finished

Checking Sidekiq ...

Running? ... yes
Number of Sidekiq processes ... 1

Checking Sidekiq ... Finished

Checking Reply by email ...

Reply by email is disabled in config/gitlab.yml

Checking Reply by email ... Finished

Checking LDAP ...

LDAP is disabled in config/gitlab.yml

Checking LDAP ... Finished

Checking GitLab ...

Git configured with autocrlf=input? ... yes
Database config exists? ... yes
All migrations up? ... yes
Database contains orphaned GroupMembers? ... no
GitLab config exists? ... yes
GitLab config outdated? ... no
Log directory writable? ... yes
Tmp directory writable? ... yes
Uploads directory setup correctly? ... skipped (no tmp uploads folder yet)
Init script exists? ... skipped (omnibus-gitlab has no init script)
Init script up-to-date? ... skipped (omnibus-gitlab has no init script)
projects have namespace: ...
1/1 ... yes
Redis version >= 2.8.0? ... yes
Ruby version >= 2.1.0 ? ... yes (2.3.3)
Your git bin path is "/opt/gitlab/embedded/bin/git"
Git version >= 2.7.3 ? ... yes (2.10.2)
Active users: 1

Checking GitLab ... Finished

Results of GitLab environment info

# docker exec -it spcbo_gitlab_ext gitlab-rake gitlab:env:info

System information
System:
Current User:   git
Using RVM:      no
Ruby Version:   2.3.3p222
Gem Version:    2.6.6
Bundler Version:1.13.7
Rake Version:   10.5.0
Redis Version:  3.2.5
Git Version:    2.10.2
Sidekiq Version:4.2.7

GitLab information
Version:        9.0.4
Revision:       63e052a
Directory:      /opt/gitlab/embedded/service/gitlab-rails
DB Adapter:     postgresql
URL:            http://spcbo-gitlab-ext.vcs.de/gitlab
HTTP Clone URL: http://spcbo-gitlab-ext.vcs.de/gitlab/some-group/some-project.git
SSH Clone URL:  git@spcbo-gitlab-ext.vcs.de:some-group/some-project.git
Using LDAP:     no
Using Omniauth: no

GitLab Shell
Version:        5.0.0
Repository storage paths:
- default:      /var/opt/gitlab/git-data/repositories
Hooks:          /opt/gitlab/embedded/service/gitlab-shell/hooks/
Git:            /opt/gitlab/embedded/bin/git

Results of GitLab application Check

See above, already given.

Possible fixes

It has to do with a change between 9.0.3-9.0.4 and similar change between 8.17.4-8.17.5.

I can confirm this bug too, I have also tryed to put plantuml in a asciidoc fence and it worked, so only markdown seems to be broken now.

Right, I was not specific enough but we only use Markdown, and that one is broken.

I can confirm that bug.

I use

• Gitlab-CE Omnibus on Ubuntu 16.04 TLS upgraded to 9.04 (63e052a)
• and a working plantuml server on Tomcat7/ubuntu 16.04

The plantUML diagrams are correctly rendered on ASCIIDOC files but a raw code block is rendered for markdown files.

But in the previous gitlab release (9.0.2 I'm not sure but I think I skipped 9.0.3), plantuml diagrams was well rendered in markdown files.

mentioned in issue #28088 (closed)

added ~65372 ~12980 markdown labels

Confirmed Bug

Steps to reproduce

1. Install the latest version of GitLab CE 9.0.5
2. Setup and configure a PlantUML server - https://docs.gitlab.com/ee/administration/integration/plantuml.html#plantuml-server
3. Add the server details to the GitLab admin settings - https://docs.gitlab.com/ee/administration/integration/plantuml.html#gitlab
4. Create a new project
5. Add a new (markdown file) file test.md with the content

```plantuml
Bob -> Alice : hello
Alice -> Bob : Go Away
```

6. View the file

Expected behaviour

PlantUML diagram is displayed

Actual behaviour

No diagram is displayed

---

Support requests

• https://gitlab.zendesk.com/agent/tickets/72489

mentioned in issue #29527 (closed)

Another support request for this: https://gitlab.zendesk.com/agent/tickets/72535.

I think this was caused by the fix to https://gitlab.com/gitlab-org/gitlab-ce/issues/30125, as https://gitlab.com/gitlab-org/gitlab-ce/blob/master/lib/banzai/filter/plantuml_filter.rb uses the class attribute. I think we should just be able to change this to lang.

added ~874211 and removed ~65372 labels

changed milestone to %9.0

assigned to @adamniedzielski

mentioned in commit e462e671

mentioned in merge request !10651 (merged)

mentioned in commit aabe95c3

mentioned in commit b7253d4d

mentioned in commit 8edcdcea

Hi @smcgivern

You tagged this issue with ML 9.0 but the merge request is tagged for 9.1. It doesn't look coherent from an outsider view.
Is that correct/to be expected?

Anyway I'm very happy to see already a first attempt at a fix. You guys are really responsive! Impressed!

@huygens I'm not sure if we will be doing another 9.0 patch If so, we could definitely include this in there, but if we aren't, then this fix will only be available in 9.1.0.

@jameslopez is another 9.0 patch on the way?

@smcgivern yes, I was planning to do another patch release this week. According to https://gitlab.com/gitlab-org/gitlab-ce/issues/24322 the MR is correctly tagged. We'll just have to update the milestone. I'll also leave a note there.

I can confirm this issue also in Gitlab-CE 9.0.5

• System information

$ sudo gitlab-rake gitlab:env:info

System information
System:         Ubuntu 16.04
Current User:   git
Using RVM:      no
Ruby Version:   2.3.3p222
Gem Version:    2.6.6
Bundler Version:1.13.7
Rake Version:   10.5.0
Redis Version:  3.2.5
Git Version:    2.10.2
Sidekiq Version:4.2.7

GitLab information
Version:        9.0.5
Revision:       a6b9899
Directory:      /opt/gitlab/embedded/service/gitlab-rails
DB Adapter:     postgresql
URL:            http://pww.gitlab.cdi.philips.com
HTTP Clone URL: http://pww.gitlab.cdi.philips.com/some-group/some-project.git
SSH Clone URL:  git@pww.gitlab.cdi.philips.com:some-group/some-project.git
Using LDAP:     yes
Using Omniauth: no

GitLab Shell
Version:        5.0.0
Repository storage paths:
- default:      /data/gitlab/git-data/repositories
Hooks:          /opt/gitlab/embedded/service/gitlab-shell/hooks/
Git:            /opt/gitlab/embedded/bin/git

• test.markdown:

• Result:

I've version 9.0.4 CE, the problem is still not solved. I'd really need this, since I've some requirements written in wiki, and the diagrams are not being shown correctly.

mentioned in commit 0945dc41

closed via merge request !10651 (merged)

mentioned in commit dinsaw/gitlab-ce@08b2e7cd

mentioned in commit d9a407d1

mentioned in commit bd2c22d6

@tiago4 either downgrade to 9.0.3 (take care, it has some security issues, so you need to make a tradeoff). Or wait for 9.0.6 which should be release soon, it contains the fix.

It seems that 9.0.6 is available and should fix this issue. My server will upgrade tomorrow, I will report on Monday if this is fixed.

I have updated our Dev GitLab server to 9.0.6 and can confirm this is working properly now

I've upgraded the gitlab-ce to 9.1.0, and this issue fixed.

Can confirm. GJ.

mentioned in issue #31366 (closed)