Update to Sidekiq 4

Is apparently 6x faster. At time of writing not yet released.

+1 => http://www.mikeperham.com/2015/11/16/sidekiq-4.0/

(Redis 2.8 or greater is now required.)

Thanks @jeffz. Not sure if redis version will be a blocker here, let's see. (feel free to explore this, if you feel inclined!)

Reassigned to @brodock

@job: sidetiq looks like to be incompatible with Sidekiq 4.0: https://github.com/tobiassvn/sidetiq/issues/145

Also incompatible with 3.5.x : https://github.com/tobiassvn/sidetiq/issues/144

We must replace it first.

Should I open another issue or address both here?

@brodock I remember there was an issue already open but could not find it. So I'd suggest to open a new one and then link this github issue as Diaspora has the same problem and there are some alternatives in that discussion.

@brodock sounds like @axil has a good proposal :)

@axil I guess this is the issue: #2355 (closed).

@dzaporozhets position was about maintaining the library. I guess with Sidekiq 4 removing celluloid it gets a little trickier.

I liked sidekiq-cron alternative, and it gives us a clear migration path:

1. Update sidekiq to 3.5 and migrate to sidekiq-cron
2. Update sidekiq to 4.0 and update sidekiq-cron

Should I reopen that issue?

@brodock Ah, I didn't look in closed issues! Yes, I believe it needs to reopen.

I also found this post from Sam Saffron, regarding their change in discourse from sidetiq to a custom code.

As by e1f293ad66d8557cca7054e82b96a4d1381d9e4a someone extracted it and made it available as sidekiq-dejavu.

will also take a look into that too

@brodock sidekiq-cron looks like a good alternative

mentioned in issue #2355 (closed)

https://github.com/felixbuenemann/sidekiq-dejavu worked for us nicely.

Thanks @yuriypadlyak. I've opted for sidekiq-cron, as it looks to be better maintained. See #2355 (closed)

Here are other relevante documentation with some considerations for the 4.0 migration: https://github.com/mperham/sidekiq/blob/master/4.0-Upgrade.md

@JobV @dzaporozhets Gitlab CE currently requires Redis 2.4+ (this is what our README file says), but Omnibus already ship with 2.8+.

By migrating sidekiq to 4.0+ we will need everybody to be using Redis 2.8+ as this is a requirement for this sidekiq version.

Do you see any problem with that? Redis website doesn't recommend anyone to run 2.6 or older

@brodock I am ok with bumping Redis dependency. We already discussed it somewhere. I think @jacobvosmaer was againsts it but I think we should do it anyway. We need update to new sidekiq anyway

See !1888 (merged).

We need to use whatever Redis Sidekiq requires.

Who is going to add documentation to the installation and upgrade guides to tell people how to install a new-enough Redis on Ubuntu 12.04?

I've updated !1888 (merged) to use Redis 2.8 and updated the installation guide. Haven't touched the upgrade guide yet.

We can either use @stanhu suggestion to install it from the tarball or use @haynes suggestion and install it from Chris Lea's PPA: https://launchpad.net/~chris-lea/+archive/ubuntu/redis-server.

Any concern @jacobvosmaer?

My proposal: Suggest Chris Lea's PPA when in Ubuntu 12.04 (packages are always better), or system redis-server for newer versions (as all of them are 2.8+ or newer)

I went with the tarball approach since I thought the instructions should be general enough for CentOS people to use them, but I do personally use the PPAs as well. :)

I agree with @stanhu 's choice for something that can be translated to Centos.

I'm ok with that , but can we suggest Ubuntu 14.04+ users to install from package? (they support 2.8).

mentioned in merge request !2057 (merged)

mentioned in commit fb07f706

Status changed to closed

Added ~122770 label

Added ~123454 label

Removed ~123454 label

Added ~123454 label

Still needs to do documentation changes https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/2057#note_3051941

Status changed to reopened

Status changed to closed