Fire update hook from GitLab
- Zendesk ticket: https://gitlab.zendesk.com/agent/tickets/10049
- Dev link: None
- GitLab version: 8.0
Expected behavior
Custom update hooks should be fired by GitLab when a commit is made via the UI.
Observed behavior
Only pre-receive and post-receive hooks are executed.
Next steps
Add support for update hook execution. @dzaporozhets and I discussed this already.
/cc @JobV
Designs
- Show closed items
Activity
-
Newest first Oldest first
-
Show all activity Show comments only Show history only
- Drew Blessing Added ~113220 label
Added ~113220 label
- Author Maintainer
Customer wonders if this can be patched. It is a regression since prior to satellite removal this hook would have been executed. They have an update hook that does strict commit message checking to align with a tracking system they use. They are concerned that if invalid commit messages are entered between now and when we fix this in a later feature release they will have problems.
- Contributor
Yes I think we should release a patch for this. cc @dzaporozhets
- Owner
Yes we can fix it. Maybe they use
pre-receive
hooks as temporary solution? - Contributor
Path for 8.1? cc @rspeicher
- Owner
@JobV Not sure what you're asking. If we have a patch ready I'll include it.
- Author Maintainer
@DouweM or @rspeicher Do you have time to look at this for an 8.1 patch release? This is a regression from 8.0 that we really need to get in.
- Owner
8.1.1 should go out today so I likely won't be able to get to it for this release.
- Contributor
Should we do this fix a a patch for 8.1, or just schedule it for 8.2?
/cc @JobV
- Author Maintainer
This is an 8.0 regression so we should strive for a patch release before 8.2.
Edited by Drew Blessing - Drew Blessing Milestone changed to 8.2
Milestone changed to 8.2
- Author Maintainer
@vsizov Can you please pick up this issue? It's a regression we've had since 8.0 and we're about to ship 8.2.
- Drew Blessing Reassigned to @vsizov
Reassigned to @vsizov
- Drew Blessing Added promised regression labels
Added promised regression labels
- Drew Blessing mentioned in issue #3530 (closed)
mentioned in issue #3530 (closed)
- Contributor
OK
- username-removed-444 Milestone changed to 8.3
Milestone changed to 8.3
- Contributor
merged. @drew Please report back.
- Robert Speicher Reassigned to @dblessing
Reassigned to @dblessing
- Author Maintainer
Reported to user. Thanks @vsizov
- Drew Blessing Status changed to closed
Status changed to closed
- Rubén Dávila mentioned in commit 338eb2c4
mentioned in commit 338eb2c4
- Rubén Dávila mentioned in commit 5e6a5270
mentioned in commit 5e6a5270
- Valery Sizov mentioned in commit 13c6096e
mentioned in commit 13c6096e
- Valery Sizov mentioned in commit tnir/gitlab-ce@13c6096e
mentioned in commit tnir/gitlab-ce@13c6096e
- Valery Sizov Mentioned in commit pfjason/gitlab-ce@13c6096e
Mentioned in commit pfjason/gitlab-ce@13c6096e
- Valery Sizov Mentioned in commit pfjason/gitlab-ce@49db8b79
Mentioned in commit pfjason/gitlab-ce@49db8b79
- Nikola Milojevic mentioned in merge request !14785
mentioned in merge request !14785