Sort environments inside environment folders

The environment themself are sorted, but opening up a folder, that list is unsorted.

@filipa Is this fixed in 9.1 when the folders were put back into the main page?

changed milestone to %9.2

@markpundsack no, we only added the folder structure back. I believe this one is backend

/cc @ayufan @grzesiek

added ~901060 label

Yes. This is pure backend. Not sure if we can solve that in %9.2.

added Stretch and removed frontend labels

@ayufan Its an order by; how hard could it be? :)

mentioned in issue #30185 (closed)

@zj Could you do that?

added Deliverable and removed Stretch labels

changed milestone to %9.3

@ayufan It sounds a tad boring, but I guess I have to

assigned to @zj

Small update, we can't use a default_scope, as this will change behaviour for the blob and commit controller. I'll probably just edit the EnvironmentsFinder to do this, but this will require us to use this in the environments controller too.

But I start to wonder if this is actually what we want. @markpundsack implies this is a bug, but the environments are sorted already, on the name, which its also GROUP BYed. It seems we would be changing behaviour. Could you confirm @markpundsack, as it seems it works better this way than what you propose.

Updated by will almost always get staging and review apps as top result, but probably alphabetically sorted is better?

assigned to @markpundsack

@zj When I reported the bug, the environment lists for folders was not sorted alphabetically, iirc. Sorting alphabetically is better than nothing, but for long lists of review apps, alphabetically isn't particularly useful.

I agree that the top-level environment list should probably be alphabetically sorted just so it stays static. Ideally, it would actually be sorted based on semantic interpretation of the environment names (review -> dev[elopment] -> staging -> qa -> UAT -> prod[uction)

As of 9.1.2-ee, it's still not sorted.

@zj Perhaps you're looking at the main list, not the environments inside folders?

assigned to @zj

review -> dev[elopment] -> staging -> qa -> UAT -> prod[uction

I wonder how you'd like to achieve this, without hardcoding it?

Anyway, indeed, the main list is sorted, inside not so much. I'll update the issue to reflect it. Please be more specific next time you open an issue like this

changed title from Sort environment folders to Sort environments inside environment folders

mentioned in commit 0385f9ef

closed via merge request !11436 (merged)

That's the point of using environments, if you sorting it by name and not by deployment index?

mentioned in commit test-nick/gitlab-ce@65d3f48f

mentioned in merge request !14785