inline issue and merge request mention status indicator shows up in wrong system notes

See the system notes of https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/9462 which also introduced this feature.

I think it shouldn't state [merged] there.

Design

Append the state only when link text is equal to the issuable reference. So:

We also change from square brackets [] to parentheses () (as we will no longer be showing status on comment mentions)

https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/9462 => !9462 (merged)
!9462 => !9462 (merged)
[something](https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/9462) => something

When linking to a comment

https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/9462#note_24341783

We will change from !9462 (comment 24341783) [merged] to !9462 (comment 24341783).

related issues

https://gitlab.com/gitlab-org/gitlab-ce/issues/30913

cc: @kushalpandya @jschatz1 @victorwu

changed milestone to %9.1

Looks like its picking those up because it contains a reference.

added ~159098 and removed frontend labels

@dimitrieh Thanks for spotting this!

I definitely agree that Compare with previous version [merged] is unexpected.

It's a link to a merge request, so it's processed by our merge request reference extractor and then IssuableStateFilter appends [merged].

I think that we should append the state only when link text is equal to the issuable reference. So:

https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/9462 => !9462 [merged]
!9462 => !9462 [merged]
[something](https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/9462) => something

The edge case is linking to a comment. If we agree on the above solution

https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/9462#note_24341783

will change from !9462 (comment 24341783) [merged] to !9462 (comment 24341783). See also https://gitlab.com/gitlab-org/gitlab-ce/issues/1369#note_27461481 /cc @deckar01

@adamniedzielski : That makes sense to me and is good conservative design that serves as a baseline. I.e. we typically only care about issue / merge request state when we are linking to that object, and not a particular element within that object.

If in the future we find some other cases where we do want to include the state, we can build on top of them then.

mentioned in issue #30913 (closed)

@adamniedzielski @victorwu seems good to me! When referring to a comment, its contents can still have meaning even when something is merged or closed... this is of less value in such a mention ;)

One small mention here, as we don't have to compete any longer with the round parentheses of the comments.. we can use these now as well, resulting in:

!9462 (merged)

the rounded parentheses make for an easier reading flow

updated issue body!

assigned to @adamniedzielski

mentioned in commit 9f68f890

mentioned in merge request !10782 (merged)

mentioned in commit ba67d11f

mentioned in commit 06df283e

mentioned in commit 1269ee4c

closed via merge request !10782 (merged)

mentioned in commit maxraab/gitlab-ce@b99853f5

mentioned in commit 65a136b4

mentioned in issue #31172 (closed)