API doesn't agree on builds_enabled vs. jobs_enabled

Summary

Documentation and JSON response from the API only use jobs_enabled while the API seems to only accept builds_enabled as a parameter.

Steps to reproduce

curl --request PUT --header "PRIVATE-TOKEN: ${PRIVATE_TOKEN}" "https://gitlab.com/api/v4/projects/${PROJECT_ID}?jobs_enabled=false"

What is the current bug behavior?

{"error":"name, description, issues_enabled, merge_requests_enabled, wiki_enabled, builds_enabled, snippets_enabled, shared_runners_enabled, container_registry_enabled, lfs_enabled, visibility, public_builds, request_access_enabled, only_allow_merge_if_pipeline_succeeds, only_allow_merge_if_all_discussions_are_resolved, path, default_branch, repository_storage, approvals_before_merge are missing, at least one parameter must be provided"}

What is the expected correct behavior?

What happens if I use builds_enabled instead:

curl --request PUT --header "PRIVATE-TOKEN: ${PRIVATE_TOKEN}" "https://gitlab.com/api/v4/projects/${PROJECT_ID}?builds_enabled=false" | grep --only-matching --extended-regexp '"(builds_enabled|jobs_enabled)"[^,]+'

"jobs_enabled":false

/cc @zj ?

The problem may be that the Projects entity still uses builds_enabled.

Also why is it jobs_enabled while the UI talks about enabling pipelines and not jobs?

@winniehell Try again today. Should be fixed in RC3.

closed

@zj I just tried again on gitlab.com (9.1.0-rc3-ee / gitlab-org/gitlab-ee@e3cefc2) and I still get the same error message.

curl \
  --request PUT \
  --header "PRIVATE-TOKEN: ${PRIVATE_TOKEN}" \
  "https://gitlab.com/api/v4/projects/${PROJECT_ID}?jobs_enabled=false"

{"error":"name, description, issues_enabled, merge_requests_enabled, wiki_enabled, builds_enabled, snippets_enabled, shared_runners_enabled, container_registry_enabled, lfs_enabled, visibility, public_builds, request_access_enabled, only_allow_merge_if_pipeline_succeeds, only_allow_merge_if_all_discussions_are_resolved, path, default_branch, repository_storage, approvals_before_merge are missing, at least one parameter must be provided"}

reopened

Was solved on this MR: https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/10586

Could you test locally? The test do have coverage for your case.

@zj !10586 (merged) is about build_events while this issue is about builds_enabled.

In RC3 / RC3 EE the Projects entity still contains builds_enabled.

I can test locally later but I doubt that it is fixed.

@winniehell Its not fixed. @ayufan Could you schedule it or so? Or shoudl I fix this

added Next Patch Release ~12980 labels

changed milestone to %9.1

@zj Can you fix it?

@ayufan I will try and hand over to @zj if I get stuck.

assigned to @winniehell

mentioned in merge request !10786 (merged)

Thanks @winniehell

closed via merge request !10786 (merged)

mentioned in commit 6b76909c

mentioned in commit 1b929586

mentioned in commit nolith/gitlab-ce@db9dd066