Unable to deactivate `Notify only default branch` in the Slack notification settings

Summary

It is not possible to persist the setting Notify only default branch in the Slack integration. Everytime when I uncheck that option and click save, it is checked again after the form has been submitted.

Steps to reproduce

• Open the Slack notifications configuration at https://host.tld/<group>/<project>/services/slack/edit
• Scroll down to the two checkboxes.
• Uncheck Notify only default branch
• Hit Save changes
• The response will have the checked setting again.

What is the current bug behavior?

It is not possible to deactivate the Notify only default branch configuration in the Slack notification settings.

What is the expected correct behavior?

Should be possible to get notifications for all branches.

Relevant logs and/or screenshots

Output of checks

Results of GitLab environment info

System information System: Debian 8.5 Current User: git Using RVM: no Ruby Version: 2.3.3p222 Gem Version: 2.6.6 Bundler Version:1.13.7 Rake Version: 10.5.0 Redis Version: 3.2.5 Git Version: 2.11.1 Sidekiq Version:4.2.7

GitLab information Version: 9.1.0 Revision: c3f0f143 Directory: /opt/gitlab/embedded/service/gitlab-rails DB Adapter: postgresql URL: https://host.tld HTTP Clone URL: https://host.tld/some-group/some-project.git SSH Clone URL: ssh://git@host.tld/some-group/some-project.git Using LDAP: no Using Omniauth: no

GitLab Shell Version: 5.0.2 Repository storage paths:

• default: /var/opt/gitlab/git-data/repositories Hooks: /opt/gitlab/embedded/service/gitlab-shell/hooks Git: /opt/gitlab/embedded/bin/git

Results of GitLab application Check

Checking GitLab Shell ...

GitLab Shell version >= 5.0.2 ? ... OK (5.0.2) Repo base directory exists? default... yes Repo storage directories are symlinks? default... no Repo paths owned by git:git? default... yes Repo paths access is drwxrws---? default... yes hooks directories in repos are links: ... 2/1 ... ok 3/2 ... ok 3/3 ... ok 3/5 ... ok 3/6 ... ok 3/7 ... ok 3/8 ... ok 4/9 ... ok 4/10 ... ok 4/11 ... ok 2/15 ... repository is empty 8/17 ... ok 8/18 ... ok 8/19 ... ok 9/20 ... ok 3/21 ... ok 11/22 ... ok 11/23 ... ok 11/24 ... ok 5/25 ... ok 5/26 ... ok 5/27 ... ok 2/28 ... ok 8/29 ... ok 8/30 ... ok 2/31 ... repository is empty 12/32 ... ok 2/33 ... ok 2/34 ... ok 15/35 ... ok 15/36 ... ok 15/37 ... ok 15/38 ... ok 2/40 ... ok 15/41 ... ok 15/43 ... ok 15/44 ... ok 15/45 ... ok 15/46 ... ok 15/47 ... ok 15/48 ... ok 15/49 ... ok 15/50 ... ok 2/51 ... ok 2/52 ... ok 15/53 ... ok 15/54 ... ok 15/55 ... ok 15/56 ... ok 15/57 ... ok 15/58 ... ok 15/59 ... ok 15/60 ... ok 15/61 ... ok 15/62 ... ok 15/64 ... ok 15/65 ... ok 43/69 ... ok 43/71 ... ok 44/72 ... ok 44/73 ... ok 44/74 ... ok 15/75 ... ok 46/78 ... repository is empty 46/80 ... repository is empty 43/81 ... ok 46/82 ... repository is empty 46/83 ... repository is empty 43/84 ... ok 15/85 ... ok Running /opt/gitlab/embedded/service/gitlab-shell/bin/check Check GitLab API access: OK Access to /var/opt/gitlab/.ssh/authorized_keys: OK Send ping to redis server: OK gitlab-shell self-check successful

Checking GitLab Shell ... Finished

Checking Sidekiq ...

Running? ... yes Number of Sidekiq processes ... 1

Checking Sidekiq ... Finished

Checking Reply by email ...

Reply by email is disabled in config/gitlab.yml

Checking Reply by email ... Finished

Checking LDAP ...

LDAP is disabled in config/gitlab.yml

Checking LDAP ... Finished

Checking GitLab ...

Git configured with autocrlf=input? ... yes Database config exists? ... yes All migrations up? ... yes Database contains orphaned GroupMembers? ... no GitLab config exists? ... yes GitLab config outdated? ... no Log directory writable? ... yes Tmp directory writable? ... yes Uploads directory setup correctly? ... yes Init script exists? ... skipped (omnibus-gitlab has no init script) Init script up-to-date? ... skipped (omnibus-gitlab has no init script) projects have namespace: ... 2/1 ... yes 3/2 ... yes 3/3 ... yes 3/5 ... yes 3/6 ... yes 3/7 ... yes 3/8 ... yes 4/9 ... yes 4/10 ... yes 4/11 ... yes 2/15 ... yes 8/17 ... yes 8/18 ... yes 8/19 ... yes 9/20 ... yes 3/21 ... yes 11/22 ... yes 11/23 ... yes 11/24 ... yes 5/25 ... yes 5/26 ... yes 5/27 ... yes 2/28 ... yes 8/29 ... yes 8/30 ... yes 2/31 ... yes 12/32 ... yes 2/33 ... yes 2/34 ... yes 15/35 ... yes 15/36 ... yes 15/37 ... yes 15/38 ... yes 2/40 ... yes 15/41 ... yes 15/43 ... yes 15/44 ... yes 15/45 ... yes 15/46 ... yes 15/47 ... yes 15/48 ... yes 15/49 ... yes 15/50 ... yes 2/51 ... yes 2/52 ... yes 15/53 ... yes 15/54 ... yes 15/55 ... yes 15/56 ... yes 15/57 ... yes 15/58 ... yes 15/59 ... yes 15/60 ... yes 15/61 ... yes 15/62 ... yes 15/64 ... yes 15/65 ... yes 43/69 ... yes 43/71 ... yes 44/72 ... yes 44/73 ... yes 44/74 ... yes 15/75 ... yes 46/78 ... yes 46/80 ... yes 43/81 ... yes 46/82 ... yes 46/83 ... yes 43/84 ... yes 15/85 ... yes Redis version >= 2.8.0? ... yes Ruby version >= 2.1.0 ? ... yes (2.3.3) Your git bin path is "/opt/gitlab/embedded/bin/git" Git version >= 2.7.3 ? ... yes (2.11.1) Active users: xx

Checking GitLab ... Finished

Possible fixes

@akoenig Thanks for the report! This is being investigated here:

• https://gitlab.com/gitlab-org/gitlab-ce/issues/31173

Closing this issue in favour of the original report

closed