/project/integrations Error 500 on old imported project

Summary

The integration page of a repo works great on a newly created repository. Even on newly created/exported/imported ones. However, accessing this page generate an error 500 on old imported repositories.

Steps to reproduce

1. import an old repo

2. go to settings->integrations

Or go to the gitlab.com importation

What is the current bug behavior?

On the project page, clicking on settings -> integrations generate an error 500

What is the expected correct behavior?

The integration page show up correctly

Relevant logs and/or screenshots

Started GET "/my_namespace/my_project/settings/integrations" for that.s.my.IP at 2017-04-27 11:51:24 +0200
Processing by Projects::Settings::IntegrationsController#show as HTML
  Parameters: {"namespace_id"=>"my_namespace", "project_id"=>"my_project"}
Completed 500 Internal Server Error in 90ms (ActiveRecord: 12.3ms)

NotImplementedError (NotImplementedError):
  app/models/service.rb:83:in `to_param'
  app/models/service.rb:79:in `to_param'
  app/models/project.rb:750:in `block in find_service'
  app/models/project.rb:750:in `find_service'
  app/models/project.rb:720:in `block in find_or_initialize_services'
  app/models/project.rb:719:in `map'
  app/models/project.rb:719:in `find_or_initialize_services'
  app/controllers/projects/settings/integrations_controller.rb:14:in `show'
  lib/gitlab/middleware/multipart.rb:93:in `call'
  lib/gitlab/request_profiler/middleware.rb:14:in `call'
  lib/gitlab/middleware/go.rb:16:in `call'
  lib/gitlab/etag_caching/middleware.rb:10:in `call'
  lib/gitlab/request_context.rb:18:in `call'

Output of checks

This bug happens on GitLab.com

Results of GitLab environment info

System information

System: Ubuntu 16.04

Current User: git

Using RVM: no

Ruby Version: 2.3.3p222

Gem Version: 2.6.6

Bundler Version:1.13.7

Rake Version: 10.5.0

Redis Version: 3.2.5

Git Version: 2.11.1

Sidekiq Version:4.2.7

GitLab information

Version: 9.1.1

Revision: d3123f67

Directory: /opt/gitlab/embedded/service/gitlab-rails

DB Adapter: postgresql

URL: http://********

HTTP Clone URL: http://********/some-group/some-project.git

SSH Clone URL: git@**********:some-group/some-project.git

Using LDAP: no

Using Omniauth: no

GitLab Shell

Version: 5.0.2

Repository storage paths:

• default: /var/opt/gitlab/git-data/repositories

Hooks: /opt/gitlab/embedded/service/gitlab-shell/hooks

Git: /opt/gitlab/embedded/bin/git

Possible fixes

Looks like this issue: #28094 (closed)

@nesnes Thanks for raising an issue. It seems that the names of services available may have changed between versions of import and export.

@jameslopez Will we need the project.json file to debug this further?

added ~480950 import needs investigation labels

This is a known issue and has been fixed recently: https://gitlab.com/gitlab-org/gitlab-ce/issues/30082

However, I'm thinking I should bump the version of the importer up so we don't encounter this again. The only solutions here is to export that project again (using a new version) or remove all the services from the project.json file and compress the export again.

Actually, no need to bump the import version up. With the fix for #30082 (closed) the import should fail. Closing this now as a duplicate.

closed

Solution

I confirm that deleting the existing services from the gitlab database solved the issue.

sudo gitlab-rails dbconsole
SELECT id FROM projects WHERE name='myProjectName';

Now we have the project ID, the following SQL commands will use the id 1234, but don't forget to replace by the one of your project.

Before running the delete command, make sure that you have a backup export of the project. There is no falling reason, but a backup is always a good idea.

SELECT type, title, active FROM services where project_id = 1234;
DELETE FROM services where project_id = 1234 AND type IS NULL;

Now you can leave the Db connection with CTRL+D and go to the integration page of your repo.

This is only deleting the corrupted services, but you might also want to remove some other:

#! OPTIONAL
DELETE FROM services where project_id = 1234 AND type='myServiceType';