Recent searches should be scoped to project

Resources

FE @MadLittleMods

Description

Right now recent searches is scoped to the instance, at least on GitLab.com. This is a bug.

It should be scoped to project. So that when I use recent searches on different projects, I see the relevant searches for the appropriate project.

added ~12980 regression labels

changed milestone to %9.1

added ~874211 frontend labels

assigned to @MadLittleMods

I don't think this is a regression . Just wasn't considered in our initial approach.

It's not a big deal if we fix this later, since this is not a huge problem, and won't cause a lot of pain.

I'm not sure what we are classifying as regressions. But if that includes obvious things we didn't consider carefully during the product-design phase or spec it explicitly, this definitely qualifies as one of those cases. The user is on the issues page of a particular project when they are using this feature. It doesn't make sense they would see searches for a totally different project. You are in a project context. You shouldn't see anything in the UI that doesn't relate to it.

changed milestone to %9.3

Let me mark this as a bug to be fixed as soon as we can for 9.3.

removed ~12980 regression labels

mentioned in commit 67a39d6e

mentioned in merge request !11142 (merged)

@victorwu Here is a fix if we want a quick merge (it still needs a test though), https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/11142

mentioned in commit 1d4ac29b

Thanks @MadLittleMods for putting this together so quickly. Let's go through the regular development flow, with code review and merge. So this should be 9.3 then since we are just passed the 9.2 freeze right?

added Deliverable label

mentioned in commit e5b10a60

mentioned in commit 25b2696d

mentioned in commit 9462a512

mentioned in commit de46c0ce

mentioned in commit cae2274f

closed via merge request !11142 (merged)

mentioned in commit cae08033

mentioned in commit nick.thomas/gitlab-ee@cc572c43

mentioned in merge request !14785