Transient failure in spec/features/boards/boards_spec.rb

As seen in https://gitlab.com/gitlab-org/gitlab-ee/builds/15901773:

  1) Issue Boards with lists closed moves issue to closed
     Failure/Error: return true if page.evaluate_script('typeof jQuery === "undefined"')

     Capybara::Poltergeist::JavascriptError:
       One or more errors were raised in the Javascript code on the page. If you don't care about these errors, you can ignore them by setting js_errors: false in your Poltergeist configuration (see documentation for details).

       Unhandled promise rejection [object Object]
       Unhandled promise rejection [object Object]
           at http://127.0.0.1:42477/assets/webpack/common.bundle.js:3342
     # ./spec/support/wait_for_ajax.rb:10:in `finished_all_ajax_requests?'
     # ./spec/support/wait_for_requests.rb:21:in `finished_all_requests?'
     # ./spec/support/wait_for_requests.rb:14:in `block in wait_for_requests_complete'
     # ./spec/support/wait_for_requests.rb:28:in `block in wait_for'
     # ./spec/support/wait_for_requests.rb:27:in `loop'
     # ./spec/support/wait_for_requests.rb:27:in `wait_for'
     # ./spec/support/wait_for_requests.rb:12:in `wait_for_requests_complete'
     # ./spec/support/wait_for_requests.rb:40:in `block (2 levels) in <top (required)>'
     # ./spec/spec_helper.rb:82:in `block (2 levels) in <top (required)>'

  2) Issue Boards with lists closed removes all of the same issue to closed
     Failure/Error: page.evaluate_script('window.activeVueResources || 0').zero?

     Capybara::Poltergeist::JavascriptError:
       One or more errors were raised in the Javascript code on the page. If you don't care about these errors, you can ignore them by setting js_errors: false in your Poltergeist configuration (see documentation for details).

       Unhandled promise rejection [object Object]
       Unhandled promise rejection [object Object]
           at http://127.0.0.1:42477/assets/webpack/common.bundle.js:3342
     # ./spec/support/wait_for_vue_resource.rb:13:in `finished_all_vue_resource_requests?'
     # ./spec/support/wait_for_requests.rb:21:in `finished_all_requests?'
     # ./spec/support/wait_for_requests.rb:14:in `block in wait_for_requests_complete'
     # ./spec/support/wait_for_requests.rb:28:in `block in wait_for'
     # ./spec/support/wait_for_requests.rb:27:in `loop'
     # ./spec/support/wait_for_requests.rb:27:in `wait_for'
     # ./spec/support/wait_for_requests.rb:12:in `wait_for_requests_complete'
     # ./spec/support/wait_for_requests.rb:40:in `block (2 levels) in <top (required)>'
     # ./spec/spec_helper.rb:82:in `block (2 levels) in <top (required)>'

  3) Issue Boards with lists lists changes position of list
     Failure/Error: return true if page.evaluate_script('typeof jQuery === "undefined"')

     Capybara::Poltergeist::JavascriptError:
       One or more errors were raised in the Javascript code on the page. If you don't care about these errors, you can ignore them by setting js_errors: false in your Poltergeist configuration (see documentation for details).

       Unhandled promise rejection [object Object]
       Unhandled promise rejection [object Object]
           at http://127.0.0.1:42477/assets/webpack/common.bundle.js:3342
     # ./spec/support/wait_for_ajax.rb:10:in `finished_all_ajax_requests?'
     # ./spec/support/wait_for_requests.rb:21:in `finished_all_requests?'
     # ./spec/support/wait_for_requests.rb:14:in `block in wait_for_requests_complete'
     # ./spec/support/wait_for_requests.rb:28:in `block in wait_for'
     # ./spec/support/wait_for_requests.rb:27:in `loop'
     # ./spec/support/wait_for_requests.rb:27:in `wait_for'
     # ./spec/support/wait_for_requests.rb:12:in `wait_for_requests_complete'
     # ./spec/support/wait_for_requests.rb:40:in `block (2 levels) in <top (required)>'
     # ./spec/spec_helper.rb:82:in `block (2 levels) in <top (required)>'

  4) Issue Boards with lists lists issue moves between lists
     Failure/Error: page.evaluate_script('jQuery.active').zero?

     Capybara::Poltergeist::JavascriptError:
       One or more errors were raised in the Javascript code on the page. If you don't care about these errors, you can ignore them by setting js_errors: false in your Poltergeist configuration (see documentation for details).

       Unhandled promise rejection [object Object]
       Unhandled promise rejection [object Object]
           at http://127.0.0.1:42477/assets/webpack/common.bundle.js:3342
     # ./spec/support/wait_for_ajax.rb:12:in `finished_all_ajax_requests?'
     # ./spec/support/wait_for_requests.rb:21:in `finished_all_requests?'
     # ./spec/support/wait_for_requests.rb:14:in `block in wait_for_requests_complete'
     # ./spec/support/wait_for_requests.rb:28:in `block in wait_for'
     # ./spec/support/wait_for_requests.rb:27:in `loop'
     # ./spec/support/wait_for_requests.rb:27:in `wait_for'
     # ./spec/support/wait_for_requests.rb:12:in `wait_for_requests_complete'
     # ./spec/support/wait_for_requests.rb:40:in `block (2 levels) in <top (required)>'
     # ./spec/spec_helper.rb:82:in `block (2 levels) in <top (required)>'

  5) Issue Boards with lists lists issue moves between lists
     Failure/Error: return true if page.evaluate_script('typeof jQuery === "undefined"')

     Capybara::Poltergeist::JavascriptError:
       One or more errors were raised in the Javascript code on the page. If you don't care about these errors, you can ignore them by setting js_errors: false in your Poltergeist configuration (see documentation for details).

       Unhandled promise rejection [object Object]
       Unhandled promise rejection [object Object]
           at http://127.0.0.1:42477/assets/webpack/common.bundle.js:3342
     # ./spec/support/wait_for_ajax.rb:10:in `finished_all_ajax_requests?'
     # ./spec/support/wait_for_requests.rb:21:in `finished_all_requests?'
     # ./spec/support/wait_for_requests.rb:14:in `block in wait_for_requests_complete'
     # ./spec/support/wait_for_requests.rb:28:in `block in wait_for'
     # ./spec/support/wait_for_requests.rb:27:in `loop'
     # ./spec/support/wait_for_requests.rb:27:in `wait_for'
     # ./spec/support/wait_for_requests.rb:12:in `wait_for_requests_complete'
     # ./spec/support/wait_for_requests.rb:40:in `block (2 levels) in <top (required)>'
     # ./spec/spec_helper.rb:82:in `block (2 levels) in <top (required)>'

  6) Issue Boards with lists lists issue moves from closed
     Failure/Error: return true if page.evaluate_script('typeof jQuery === "undefined"')

     Capybara::Poltergeist::JavascriptError:
       One or more errors were raised in the Javascript code on the page. If you don't care about these errors, you can ignore them by setting js_errors: false in your Poltergeist configuration (see documentation for details).

       Unhandled promise rejection [object Object]
       Unhandled promise rejection [object Object]
           at http://127.0.0.1:42477/assets/webpack/common.bundle.js:3342
     # ./spec/support/wait_for_ajax.rb:10:in `finished_all_ajax_requests?'
     # ./spec/support/wait_for_requests.rb:21:in `finished_all_requests?'
     # ./spec/support/wait_for_requests.rb:14:in `block in wait_for_requests_complete'
     # ./spec/support/wait_for_requests.rb:28:in `block in wait_for'
     # ./spec/support/wait_for_requests.rb:27:in `loop'
     # ./spec/support/wait_for_requests.rb:27:in `wait_for'
     # ./spec/support/wait_for_requests.rb:12:in `wait_for_requests_complete'
     # ./spec/support/wait_for_requests.rb:40:in `block (2 levels) in <top (required)>'
     # ./spec/spec_helper.rb:82:in `block (2 levels) in <top (required)>'

Finished in 21 minutes 20 seconds (files took 20.71 seconds to load)
1505 examples, 6 failures, 4 pending

Failed examples:

rspec ./spec/features/boards/boards_spec.rb:194 # Issue Boards with lists closed moves issue to closed
rspec ./spec/features/boards/boards_spec.rb:207 # Issue Boards with lists closed removes all of the same issue to closed
rspec ./spec/features/boards/boards_spec.rb:221 # Issue Boards with lists lists changes position of list
rspec ./spec/features/boards/boards_spec.rb:232 # Issue Boards with lists lists issue moves between lists
rspec ./spec/features/boards/boards_spec.rb:243 # Issue Boards with lists lists issue moves between lists
rspec ./spec/features/boards/boards_spec.rb:254 # Issue Boards with lists lists issue moves from closed

added frontend label

I've got a fix ready. Creating a branch now...

The gist is, these errors never surfaced before until the changes in !9846 (merged) caused them to show up. The changes in !9846 (merged) are not bad, they just merely shed light on errors that were previously going unnoticed, namely how we handle failed AJAX requests.

created branch 32030-transient-failure-in-spec-features-boards-boards_spec-rb

mentioned in merge request !11222 (merged)

closed via merge request !11222 (merged)

mentioned in commit c3fa0b62